Re: [Intel-xe] [RFC PATCH 04/20] fixup! drm/xe/display: Implement display support

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, May 08, 2023 at 09:19:48AM +0000, Hogander, Jouni wrote:
> On Fri, 2023-05-05 at 10:44 -0400, Rodrigo Vivi wrote:
> > 
> > I believe we could already start merging patches 1-4, no?!
> 
> Patches 1-4 alone are currently breaking build. I can fix that. 

That shouldn't ever happen anyway.

Every single patch needs to build and be self-sufficient, otherwise
we break bisects and auto-bisects.

> 
> Generally: in current form GPU frontbuffer rendering + PSR,FBC doesn't
> work with Xe driver in drm-xe-next branch. Additionally it is breaking
> it for i915 as well. If patches 1-4 are applied i915 GPU frontbuffer
> rendering + PSR,FBC is not broken anymore. Drawback is that neither CPU
> or GPU fronbuffer rendering + PSR,FBC is working anymore with Xe
> driver. Subsequent patches are fixing that.
> > 
> > Maarten?
> > 
> > On Fri, May 05, 2023 at 11:29:40AM +0300, Jouni Högander wrote:
> > > Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> > > ---
> > >  drivers/gpu/drm/xe/display/xe_plane_initial.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/xe/display/xe_plane_initial.c
> > > b/drivers/gpu/drm/xe/display/xe_plane_initial.c
> > > index d0f91f37b6d8..34ae461865a7 100644
> > > --- a/drivers/gpu/drm/xe/display/xe_plane_initial.c
> > > +++ b/drivers/gpu/drm/xe/display/xe_plane_initial.c
> > > @@ -228,7 +228,7 @@ intel_find_initial_plane_obj(struct intel_crtc
> > > *crtc,
> > >         plane_state->uapi.crtc = &crtc->base;
> > >         intel_plane_copy_uapi_to_hw_state(plane_state, plane_state,
> > > crtc);
> > >  
> > > -       atomic_or(plane->frontbuffer_bit,
> > > &to_intel_framebuffer(fb)->bits);
> > > +       atomic_or(plane->frontbuffer_bit,
> > > &to_intel_frontbuffer(fb)->bits);
> > >  
> > >         plane_config->vma = vma;
> > >  
> > > -- 
> > > 2.34.1
> > > 
>