From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH v2 3/6] drm/xe: Replace list_del_init with list_del for userptr.invalidate_link cleanup
Date: Thu, 20 Jul 2023 11:53:10 -0400 [thread overview]
Message-ID: <ZLlYZgXxIu12rj91@intel.com> (raw)
In-Reply-To: <20230720041057.112903-4-matthew.brost@intel.com>
On Wed, Jul 19, 2023 at 09:10:54PM -0700, Matthew Brost wrote:
> This list isn't used again, list_del is the proper call.
>
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/xe/xe_vm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 87faf4b723b3..1ed3bc2541f2 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -1065,7 +1065,7 @@ static void xe_vma_destroy(struct xe_vma *vma, struct dma_fence *fence)
> XE_WARN_ON(!(vma->gpuva.flags & XE_VMA_DESTROYED));
>
> spin_lock(&vm->userptr.invalidated_lock);
> - list_del_init(&vma->userptr.invalidate_link);
> + list_del(&vma->userptr.invalidate_link);
> spin_unlock(&vm->userptr.invalidated_lock);
> } else if (!xe_vma_is_null(vma)) {
> xe_bo_assert_held(xe_vma_bo(vma));
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-07-20 15:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 4:10 [Intel-xe] [PATCH v2 0/6] More VM cleanups Matthew Brost
2023-07-20 4:10 ` [Intel-xe] [PATCH v2 1/6] drm/xe: Avoid doing rebinds Matthew Brost
2023-07-20 15:56 ` Rodrigo Vivi
2023-07-20 4:10 ` [Intel-xe] [PATCH v2 2/6] drm/xe: Reduce the number list links in xe_vma Matthew Brost
2023-07-20 4:10 ` [Intel-xe] [PATCH v2 3/6] drm/xe: Replace list_del_init with list_del for userptr.invalidate_link cleanup Matthew Brost
2023-07-20 15:53 ` Rodrigo Vivi [this message]
2023-07-20 4:10 ` [Intel-xe] [PATCH v2 4/6] drm/xe: Change tile masks from u64 to u8 Matthew Brost
2023-07-20 15:48 ` Rodrigo Vivi
2023-07-20 4:10 ` [Intel-xe] [PATCH v2 5/6] drm/xe: Combine destroy_cb and destroy_work in xe_vma into union Matthew Brost
2023-07-20 4:10 ` [Intel-xe] [PATCH v2 6/6] drm/xe: Only alloc userptr part of xe_vma for userptrs Matthew Brost
2023-07-20 4:13 ` [Intel-xe] ✗ CI.Patch_applied: failure for More VM cleanups (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLlYZgXxIu12rj91@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox