From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH v4 1/7] drm/xe: Remove xe_vma_op_unmap
Date: Thu, 20 Jul 2023 17:09:55 -0400 [thread overview]
Message-ID: <ZLmio8CGxE27hUst@intel.com> (raw)
In-Reply-To: <20230720155546.199766-2-matthew.brost@intel.com>
On Thu, Jul 20, 2023 at 08:55:40AM -0700, Matthew Brost wrote:
> xe_vma_op_unmap isn't used, remove it.
>
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/xe/xe_vm.c | 5 -----
> drivers/gpu/drm/xe/xe_vm_types.h | 10 ----------
> 2 files changed, 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index f8e6f1fda1fe..63c9e1c94515 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -2516,11 +2516,6 @@ static int vm_bind_ioctl_ops_parse(struct xe_vm *vm, struct xe_engine *e,
> xe_vma_size(gpuva_to_vma(op->base.remap.unmap->va));
> break;
> case DRM_GPUVA_OP_UNMAP:
> - op->unmap.start =
> - xe_vma_start(gpuva_to_vma(op->base.unmap.va));
> - op->unmap.range =
> - xe_vma_size(gpuva_to_vma(op->base.unmap.va));
> - break;
> case DRM_GPUVA_OP_PREFETCH:
> /* Nothing to do */
> break;
> diff --git a/drivers/gpu/drm/xe/xe_vm_types.h b/drivers/gpu/drm/xe/xe_vm_types.h
> index bcbcad1929d6..ce26298d7a5f 100644
> --- a/drivers/gpu/drm/xe/xe_vm_types.h
> +++ b/drivers/gpu/drm/xe/xe_vm_types.h
> @@ -333,14 +333,6 @@ struct xe_vma_op_map {
> bool is_null;
> };
>
> -/** struct xe_vma_op_unmap - VMA unmap operation */
> -struct xe_vma_op_unmap {
> - /** @start: start of the VMA unmap */
> - u64 start;
> - /** @range: range of the VMA unmap */
> - u64 range;
> -};
> -
> /** struct xe_vma_op_remap - VMA remap operation */
> struct xe_vma_op_remap {
> /** @prev: VMA preceding part of a split mapping */
> @@ -408,8 +400,6 @@ struct xe_vma_op {
> union {
> /** @map: VMA map operation specific data */
> struct xe_vma_op_map map;
> - /** @unmap: VMA unmap operation specific data */
> - struct xe_vma_op_unmap unmap;
> /** @remap: VMA remap operation specific data */
> struct xe_vma_op_remap remap;
> /** @prefetch: VMA prefetch operation specific data */
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-07-20 21:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 15:55 [Intel-xe] [PATCH v4 0/7] More VM cleanups Matthew Brost
2023-07-20 15:55 ` [Intel-xe] [PATCH v4 1/7] drm/xe: Remove xe_vma_op_unmap Matthew Brost
2023-07-20 21:09 ` Rodrigo Vivi [this message]
2023-07-20 15:55 ` [Intel-xe] [PATCH v4 2/7] drm/xe: Avoid doing rebinds Matthew Brost
2023-07-20 15:55 ` [Intel-xe] [PATCH v4 3/7] drm/xe: Reduce the number list links in xe_vma Matthew Brost
2023-07-20 15:55 ` [Intel-xe] [PATCH v4 4/7] drm/xe: Replace list_del_init with list_del for userptr.invalidate_link cleanup Matthew Brost
2023-07-20 15:55 ` [Intel-xe] [PATCH v4 5/7] drm/xe: Change tile masks from u64 to u8 Matthew Brost
2023-07-20 15:55 ` [Intel-xe] [PATCH v4 6/7] drm/xe: Combine destroy_cb and destroy_work in xe_vma into union Matthew Brost
2023-07-20 15:55 ` [Intel-xe] [PATCH v4 7/7] drm/xe: Only alloc userptr part of xe_vma for userptrs Matthew Brost
2023-07-20 16:47 ` [Intel-xe] ✓ CI.Patch_applied: success for More VM cleanups (rev4) Patchwork
2023-07-20 16:48 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-07-20 16:49 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-07-20 16:53 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-07-20 16:53 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-07-20 16:54 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLmio8CGxE27hUst@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox