Re: [Intel-xe] [PATCH v9 1/3] fault-inject: Include linux/types.h by default.

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Jul 27, 2023 at 04:56:48AM +0530, Himal Prasad Ghimiray wrote:
> Functions should_fail_alloc_page, should_failslab, and __should_failslab
> are declared irrespective of CONFIG_FAULT_INJECTION. These functions use
> bool and gfp_t types, which are treated as unknown when
> CONFIG_FAULT_INJECTION is disabled because the inclusion of linux/types.h
> is missing.
> 
> Fixes: 6ff1cb355e62 ("[PATCH] fault-injection capabilities infrastructure")
> 
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Badal Nilawar <badal.nilawar@intel.com>
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> ---
> v2:
> - Add fixes tag (Badal)
> - Rectify Cc. (Lucas)

and now you removed the correct cc folks..

Okay, so, I'm pushing this exact version to our drm-xe-next in a hope that
we will get this patch sorted out before we are ready for the first
pull request towards drm-next...

We will later remove this patch anyway before the drm-next submission and
only add as a topic/core-for-CI if still needed.

Himal, please continue working with the community there to get this
fixed upstream. Resend the v2 standalone, but without the version history to
the lklm and to the maintainers.

> 
>  include/linux/fault-inject.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/fault-inject.h b/include/linux/fault-inject.h
> index 481abf530b3c..f83ab2b6cd08 100644
> --- a/include/linux/fault-inject.h
> +++ b/include/linux/fault-inject.h
> @@ -2,9 +2,10 @@
>  #ifndef _LINUX_FAULT_INJECT_H
>  #define _LINUX_FAULT_INJECT_H
>  
> +#include <linux/types.h>
> +
>  #ifdef CONFIG_FAULT_INJECTION
>  
> -#include <linux/types.h>
>  #include <linux/debugfs.h>
>  #include <linux/configfs.h>
>  #include <linux/ratelimit.h>
> -- 
> 2.25.1
>