Re: [Intel-xe] [PATCH] drm/xe/mtl: Reduce Wa_14018575942 scope to the CCS engine

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Jul 28, 2023 at 10:56:02AM -0700, Matt Roper wrote:
> The MTL version of Wa_14018575942 has been updated to suggest only
> applying the register change on the CCS engine.
> 
> Note that DG2 and PVC have a functionally equivalent workaround with
> Wa_18018781329; for now that one is still applying to all engines,
> although we'll keep an eye on it in case it changes to be CCS-specific
> too.

I just noticed there are changes in DG2 recommendation as well.
Please check 14015427992.

In PVC it probably doesn't matter much because no usage on RCS or
media engines...

for this one here anyway:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> 
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_wa.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
> index 497a8c05c715..5cf84a096302 100644
> --- a/drivers/gpu/drm/xe/xe_wa.c
> +++ b/drivers/gpu/drm/xe/xe_wa.c
> @@ -238,21 +238,13 @@ static const struct xe_rtp_entry_sr gt_was[] = {
>  	},
>  	{ XE_RTP_NAME("14018575942"),
>  	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1270, 1271)),
> -	  XE_RTP_ACTIONS(SET(RENDER_MOD_CTRL, FORCE_MISS_FTLB),
> -			 SET(COMP_MOD_CTRL, FORCE_MISS_FTLB))
> +	  XE_RTP_ACTIONS(SET(COMP_MOD_CTRL, FORCE_MISS_FTLB))
>  	},
>  	{ XE_RTP_NAME("22016670082"),
>  	  XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1270, 1271)),
>  	  XE_RTP_ACTIONS(SET(SQCNT1, ENFORCE_RAR))
>  	},
>  
> -	/* Xe_LPM+ */
> -	{ XE_RTP_NAME("14018575942"),
> -	  XE_RTP_RULES(MEDIA_VERSION(1300)),
> -	  XE_RTP_ACTIONS(SET(XELPMP_VDBX_MOD_CTRL, FORCE_MISS_FTLB),
> -			 SET(XELPMP_VEBX_MOD_CTRL, FORCE_MISS_FTLB))
> -	},
> -
>  	{}
>  };
>  
> -- 
> 2.41.0
>