From: Matthew Brost <matthew.brost@intel.com>
To: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH] fixup! drm/xe/guc: Report submission version of GuC firmware
Date: Wed, 30 Aug 2023 01:00:04 +0000 [thread overview]
Message-ID: <ZO6UlFl0GjHnEPky@DUT025-TGLU.fm.intel.com> (raw)
In-Reply-To: <20230829233053.2264563-1-daniele.ceraolospurio@intel.com>
On Tue, Aug 29, 2023 at 04:30:53PM -0700, Daniele Ceraolo Spurio wrote:
> Major GuC versions greater than 70 will have the submission version in
> the herader irrespective of their minor version number.
>
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> Cc: John Harrison <John.C.Harrison@Intel.com>
> ---
> drivers/gpu/drm/xe/xe_uc_fw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_uc_fw.c b/drivers/gpu/drm/xe/xe_uc_fw.c
> index e2f42f1bc89a..37ad238148b0 100644
> --- a/drivers/gpu/drm/xe/xe_uc_fw.c
> +++ b/drivers/gpu/drm/xe/xe_uc_fw.c
> @@ -252,7 +252,7 @@ static void guc_read_css_info(struct xe_uc_fw *uc_fw, struct uc_css_header *css)
> XE_WARN_ON(uc_fw->type != XE_UC_FW_TYPE_GUC);
> XE_WARN_ON(uc_fw->major_ver_found < 70);
>
> - if (uc_fw->minor_ver_found >= 6) {
> + if (uc_fw->major_ver_found > 70 || uc_fw->minor_ver_found >= 6) {
> /* v70.6.0 adds CSS header support */
> guc->submission_state.version.major =
> FIELD_GET(CSS_SW_VERSION_UC_MAJOR,
> --
> 2.41.0
>
next prev parent reply other threads:[~2023-08-30 1:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 23:30 [Intel-xe] [PATCH] fixup! drm/xe/guc: Report submission version of GuC firmware Daniele Ceraolo Spurio
2023-08-30 0:05 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
2023-08-30 0:05 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-30 0:06 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-30 0:13 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-08-30 0:13 ` [Intel-xe] ✗ CI.Hooks: failure " Patchwork
2023-08-30 1:00 ` Matthew Brost [this message]
2023-09-05 23:45 ` [Intel-xe] ✓ CI.Patch_applied: success for fixup! drm/xe/guc: Report submission version of GuC firmware (rev2) Patchwork
2023-09-05 23:45 ` [Intel-xe] ✓ CI.checkpatch: " Patchwork
2023-09-05 23:46 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-09-05 23:53 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-05 23:54 ` [Intel-xe] ✗ CI.Hooks: failure " Patchwork
2023-09-05 23:55 ` [Intel-xe] ✓ CI.checksparse: success " Patchwork
2023-09-07 10:37 ` [Intel-xe] ✓ CI.Patch_applied: success for fixup! drm/xe/guc: Report submission version of GuC firmware (rev3) Patchwork
2023-09-07 10:37 ` [Intel-xe] ✓ CI.checkpatch: " Patchwork
2023-09-07 10:39 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-09-07 10:46 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-07 10:46 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-07 10:47 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-09-07 11:20 ` [Intel-xe] ✗ CI.BAT: failure " Patchwork
2023-09-14 18:49 ` [Intel-xe] ✗ CI.Patch_applied: failure for fixup! drm/xe/guc: Report submission version of GuC firmware (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO6UlFl0GjHnEPky@DUT025-TGLU.fm.intel.com \
--to=matthew.brost@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox