From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 063D1CE7A89 for ; Mon, 25 Sep 2023 08:59:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C283E10E036; Mon, 25 Sep 2023 08:59:07 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4656610E036 for ; Mon, 25 Sep 2023 08:59:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695632346; x=1727168346; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=DpzYbxHKQe8xTQumEp2zADmckU9uFjL6UbWNWPbpHvU=; b=PbW8JTo/eUez/NrA2afcszhmHU2+jxfY8WhQG5Y3fMcK00U94zJNlk2q muUsViDodsPmyXzbO5z/7gH8nVb5IuaFxHUG5w+bM6BaHTU7GgG1kMIIH jzCY6kpq2OnUjfz1zXWLtRIyD89hY2M/gGsRhplC7ptgVWU9ssAvJUvpf W2sHRXY70WYlA+uJ9W8WwoBy0+Ml1qwA7R4XJ7ZpjNBPxIhvKSMbN4gzP Y7o95TlkeoBseXjG5kLZsxJH1eduBGpvohuednByT834GEsZXLx1KQpHO LnHKDxPdhO8j8lc8hetdYqr0Bu7pTay8RYEjBvXEg8Virgb3CqsEyCgXt w==; X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="380078850" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="380078850" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2023 01:59:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="863794257" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="863794257" Received: from nurqayrx-mobl2.gar.corp.intel.com (HELO intel.com) ([10.213.34.118]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2023 01:58:59 -0700 Date: Mon, 25 Sep 2023 10:58:52 +0200 From: Andi Shyti To: Badal Nilawar Message-ID: References: <20230925081842.3566834-1-badal.nilawar@intel.com> <20230925081842.3566834-2-badal.nilawar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230925081842.3566834-2-badal.nilawar@intel.com> Subject: Re: [Intel-xe] [PATCH v6 1/5] drm/xe/hwmon: Expose power attributes X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, rodrigo.vivi@intel.com, intel-xe@lists.freedesktop.org, linux@roeck-us.net Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Hi Badal, On Mon, Sep 25, 2023 at 01:48:38PM +0530, Badal Nilawar wrote: > Expose Card reactive sustained (pl1) power limit as power_max and > card default power limit (tdp) as power_rated_max. > > v2: > - Fix review comments (Riana) > v3: > - Use drmm_mutex_init (Matt Brost) > - Print error value (Matt Brost) > - Convert enums to uppercase (Matt Brost) > - Avoid extra reg read in hwmon_is_visible function (Riana) > - Use xe_device_assert_mem_access when applicable (Matt Brost) > - Add intel-xe@lists.freedesktop.org in Documentation (Matt Brost) > v4: > - Use prefix xe_hwmon prefix for all functions (Matt Brost/Andi) > - %s/hwmon_reg/xe_hwmon_reg (Andi) > - Fix review comments (Guenter/Andi) > v5: > - Fix review comments (Riana) > v6: > - Use drm_warn in default case (Rodrigo) > - s/ENODEV/EOPNOTSUPP (Andi) > > Acked-by: Rodrigo Vivi > Reviewed-by: Riana Tauro > Signed-off-by: Badal Nilawar looks good to me: Reviewed-by: Andi Shyti Andi