From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 2/2] drm/xe: Add a missing mutex_destroy to xe_ttm_vram_mgr
Date: Thu, 28 Sep 2023 19:18:24 -0400 [thread overview]
Message-ID: <ZRYJwP4FQm1AslSj@intel.com> (raw)
In-Reply-To: <ZRSSyoYJRa18aXEM@nvishwa1-DESK>
On Wed, Sep 27, 2023 at 01:38:34PM -0700, Niranjana Vishwanathapura wrote:
> On Wed, Sep 27, 2023 at 04:50:12PM +0000, Bommithi Sakeena wrote:
> > Ensure that the mutex is destroyed at fini function.
> >
> > Fixes: e777edb47dc2 ("drm/xe: Implement stolen memory.")
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Signed-off-by: Bommithi Sakeena <bommithi.sakeena@intel.com>
>
> Can we use 'fixup!' tag (instead of 'Fixes') if it can be
> squashed with the originating patch?
> In either case,
> Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
I'm taking the patch here to preserve the credits as is and
remove the Fixes tag. Since the patches are going together anyway.
>
> > ---
> > drivers/gpu/drm/xe/xe_ttm_vram_mgr.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c b/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
> > index 06a54c8bd46f..285791eb4a79 100644
> > --- a/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
> > +++ b/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
> > @@ -328,6 +328,8 @@ static void ttm_vram_mgr_fini(struct drm_device *dev, void *arg)
> > ttm_resource_manager_cleanup(&mgr->manager);
> >
> > ttm_set_driver_manager(&xe->ttm, mgr->mem_type, NULL);
> > +
> > + mutex_destroy(&mgr->lock);
> > }
> >
> > int __xe_ttm_vram_mgr_init(struct xe_device *xe, struct xe_ttm_vram_mgr *mgr,
> > --
> > 2.34.1
> >
next prev parent reply other threads:[~2023-09-28 23:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 16:50 [Intel-xe] [PATCH 1/2] drm/xe: Ensure mutex are destroyed Bommithi Sakeena
2023-09-27 16:50 ` [Intel-xe] [PATCH 2/2] drm/xe: Add a missing mutex_destroy to xe_ttm_vram_mgr Bommithi Sakeena
2023-09-27 20:38 ` Niranjana Vishwanathapura
2023-09-28 23:18 ` Rodrigo Vivi [this message]
2023-09-27 16:52 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe: Ensure mutex are destroyed Patchwork
2023-09-27 16:52 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-27 16:53 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-27 17:00 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-27 17:01 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-27 17:02 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-09-27 17:36 ` [Intel-xe] ✗ CI.BAT: failure " Patchwork
2023-09-27 20:37 ` [Intel-xe] [PATCH 1/2] " Niranjana Vishwanathapura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRYJwP4FQm1AslSj@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=niranjana.vishwanathapura@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox