Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
To: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 1/3] drm/xe/vm: print the correct 'keep' when printing gpuva ops
Date: Fri, 29 Sep 2023 22:21:40 -0700	[thread overview]
Message-ID: <ZRewZJsTcFKR6qop@nvishwa1-DESK> (raw)
In-Reply-To: <20230929173104.2014590-1-paulo.r.zanoni@intel.com>

On Fri, Sep 29, 2023 at 10:31:02AM -0700, Paulo Zanoni wrote:
>Unions are cool, until they aren't.
>
>Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>---
> drivers/gpu/drm/xe/xe_vm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
>index 57ffac324564..e72380cc832e 100644
>--- a/drivers/gpu/drm/xe/xe_vm.c
>+++ b/drivers/gpu/drm/xe/xe_vm.c
>@@ -2351,7 +2351,7 @@ static void print_op(struct xe_device *xe, struct drm_gpuva_op *op)
> 		vma = gpuva_to_vma(op->remap.unmap->va);
> 		vm_dbg(&xe->drm, "REMAP:UNMAP: addr=0x%016llx, range=0x%016llx, keep=%d",
> 		       (ULL)xe_vma_start(vma), (ULL)xe_vma_size(vma),
>-		       op->unmap.keep ? 1 : 0);
>+		       op->remap.unmap->keep ? 1 : 0);

Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>

> 		if (op->remap.prev)
> 			vm_dbg(&xe->drm,
> 			       "REMAP:PREV: addr=0x%016llx, range=0x%016llx",
>-- 
>2.39.2
>

      parent reply	other threads:[~2023-09-30  5:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-29 17:31 [Intel-xe] [PATCH 1/3] drm/xe/vm: print the correct 'keep' when printing gpuva ops Paulo Zanoni
2023-09-29 17:31 ` [Intel-xe] [PATCH 2/3] drm/xe/vm: use list_last_entry() to fetch last_op Paulo Zanoni
2023-09-30  5:22   ` Niranjana Vishwanathapura
2023-09-29 17:31 ` [Intel-xe] [PATCH 3/3] drm/xe: fix range printing for debug messages Paulo Zanoni
2023-09-30  5:24   ` Niranjana Vishwanathapura
2023-10-04 13:18     ` Rodrigo Vivi
2023-09-29 18:21 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [1/3] drm/xe/vm: print the correct 'keep' when printing gpuva ops Patchwork
2023-09-29 18:21 ` [Intel-xe] ✓ CI.checkpatch: " Patchwork
2023-09-29 18:22 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-09-29 18:29 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-29 18:29 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-29 18:31 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-09-29 19:03 ` [Intel-xe] ✓ CI.BAT: " Patchwork
2023-09-30  5:21 ` Niranjana Vishwanathapura [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZRewZJsTcFKR6qop@nvishwa1-DESK \
    --to=niranjana.vishwanathapura@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox