From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "Michał Winiarski" <michal.winiarski@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 1/3] drm/xe: Fix header guard warning
Date: Wed, 18 Oct 2023 09:27:27 -0400 [thread overview]
Message-ID: <ZS/dP1fdTtwUJ7Wd@intel.com> (raw)
In-Reply-To: <20231018115826.3908905-2-michal.winiarski@intel.com>
On Wed, Oct 18, 2023 at 01:58:24PM +0200, Michał Winiarski wrote:
> Additional underscore in the header guard causes the build to fail with:
>
> drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.h:6:9: error: '_XE_ENGINE_CLASS_SYSFS_H_' is used as a header guard here, followed by #define of a different macro [-Werror,-Wheader-guard]
>
> Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.h b/drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.h
> index 60469fde41478..ec5ba673b314b 100644
> --- a/drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.h
> +++ b/drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.h
> @@ -4,7 +4,7 @@
> */
>
> #ifndef _XE_ENGINE_CLASS_SYSFS_H_
> -#define _XE_ENGINE_CLASS_SYSFS_H__
> +#define _XE_ENGINE_CLASS_SYSFS_H_
>
> #include <linux/kobject.h>
>
> --
> 2.42.0
>
next prev parent reply other threads:[~2023-10-18 13:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 11:58 [Intel-xe] [PATCH 0/3] drm/xe: Fix building with clang Michał Winiarski
2023-10-18 11:58 ` [Intel-xe] [PATCH 1/3] drm/xe: Fix header guard warning Michał Winiarski
2023-10-18 13:27 ` Rodrigo Vivi [this message]
2023-10-18 11:58 ` [Intel-xe] [PATCH 2/3] drm/i915: Fix uninitialized variable warning Michał Winiarski
2023-10-18 13:27 ` Rodrigo Vivi
2023-10-18 16:54 ` Lucas De Marchi
2023-10-19 12:55 ` Upadhyay, Tejas
2023-10-24 10:50 ` Jani Nikula
2023-10-18 11:58 ` [Intel-xe] [PATCH 3/3] drm/xe: Fix format string security warning Michał Winiarski
2023-10-18 13:28 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS/dP1fdTtwUJ7Wd@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.winiarski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox