Re: [Intel-xe] [RFC] drm/xe: A minimal assert for some forcewake domain on xe_mmio.

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Oct 19, 2023 at 11:43:10AM +0300, Luca Coelho wrote:
> On Tue, 2023-10-17 at 11:12 -0400, Rodrigo Vivi wrote:
> > On Mon, Oct 16, 2023 at 05:58:41PM -0700, Matt Roper wrote:
> > > On Mon, Oct 16, 2023 at 06:10:14PM -0400, Rodrigo Vivi wrote:
> > > > On Tue, Oct 17, 2023 at 12:33:39AM +0300, Luca Coelho wrote:
> > > > 
> > > > > But maybe I misunderstood the proposal.  And, if this is not the plan,
> > > > > then the only way to do it is to add the "wakelock" logic to the
> > > > > display orthogonally to the general MMIO access operations, which I
> > > > > wanted to avoid.
> > > > 
> > > > well, let's have it inside intel_de_ and we have only one implementation.
> > > > no port needed. Regardless of the future of the xe_mmio or the future
> > > > of xe_forcewake.
> > > 
> > > Implementing it solely at the intel_de layer sounds reasonable to me as
> > > well.
> > 
> > yeap, they appear to be orthogonal discussions. Even going with the
> > intrinsic forcewake inside xe_mmio, I still believe that the right place
> > for this wakelock is inside intel_de anyway.
> 
> Thanks for all the comments and helping me understand this a bit
> better.  The way I saw it was that Xe would be where underlying HW
> access is implemented, so to me it would make sense to have this HW
> access restriction (regardless of being used only by the display)
> there.  I don't think it's a "display thing", but a HW limitation that
> affects only the display.

I believe the best way to see this is the display driver driving the
display IP block, regardless of which driver it is 'paired' with.

So, it drives the hardware...  at least the display block of the hardware.

Then, the side driver provides a path to the basic hw *access* and
basic *resouces*, only because we are in the same pci card and share
some of the resources.

> 
> In any case, doing it entirely in intel_de is probably the easiest
> thing to do, so let's go with that.
> 
> --
> Cheers,
> Luca.