Re: [Intel-xe] [PATCH 1/2] fixup! drm/xe/display: Implement display support

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Nov 09, 2023 at 09:51:31AM -0800, Lucas De Marchi wrote:
> Due to the way we build i915-display for Xe, we can't have both i915 and
> xe as builtin, otherwise there will be symbols defined twice. This can
> be improved later by renaming the symbols in the source (redirecting via
> macros) or during build via linker/objcopy.
> 
> For now, just fix alleyesconfig. If i915 was not selected it could
> be left builtin, but it'd be a weird dependency on another driver. So,
> just make de dependency be "if display is selected, xe must be built as
> module".
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
> index c66c4466e8b8..2fa2d6dacb96 100644
> --- a/drivers/gpu/drm/xe/Kconfig
> +++ b/drivers/gpu/drm/xe/Kconfig
> @@ -47,7 +47,7 @@ config DRM_XE
>  
>  config DRM_XE_DISPLAY
>  	bool "Enable display support"
> -	depends on DRM_XE && EXPERT
> +	depends on DRM_XE && EXPERT && DRM_XE=m
>  	select FB_IOMEM_HELPERS
>  	select I2C
>  	select I2C_ALGOBIT
> -- 
> 2.40.1
>