From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH] drm/xe: Encapsulate all the module parameters
Date: Mon, 13 Nov 2023 14:52:35 -0500 [thread overview]
Message-ID: <ZVJ+g0thqwosQbAA@intel.com> (raw)
In-Reply-To: <ksztic5tu4wjapm5jkyqfbcbjoen2364iemdrtjh5y3u6jgm5t@v47f5rt6wws5>
On Mon, Nov 13, 2023 at 08:23:34AM -0600, Lucas De Marchi wrote:
> On Thu, Nov 09, 2023 at 05:47:09PM +0000, Bommithi Sakeena wrote:
> > Encapsulate all the module parameters in one single global struct
> > variable. This also removes the extra xe_module.h from includes.
> >
> > v2: naming consistency as suggested by Jani and Lucas
> > v3: fix checkpatch errors/warnings
>
> checkpatch CI check is still complaining. You can reproduce it locally
> by running
>
> dim checkpatch HEAD^..HEAD drm-intel
>
> assuming you have this commit as top-most commit in your branch.
hmm... is this the --strict option?
apparently that would pass the pain ./scritpts/checkpatch...
the equivalent without dim to reproduce this would be:
./scripts/checkpatch.pl -q --emacs --strict --show-types --max-line-length=100 --ignore=BIT_MACRO,SPLIT_STRING,LONG_LINE_STRING,BOOL_MEMBER <patch file>
>
> Lucas De Marchi
next prev parent reply other threads:[~2023-11-13 19:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 17:47 [Intel-xe] [PATCH] drm/xe: Encapsulate all the module parameters Bommithi Sakeena
2023-11-10 21:01 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: Encapsulate all the module parameters (rev4) Patchwork
2023-11-10 21:01 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-11-10 21:02 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-11-10 21:10 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-11-10 21:10 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-11-10 21:11 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-11-10 21:41 ` [Intel-xe] ✗ CI.BAT: failure " Patchwork
2023-11-13 14:23 ` [Intel-xe] [PATCH] drm/xe: Encapsulate all the module parameters Lucas De Marchi
2023-11-13 19:52 ` Rodrigo Vivi [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-11-17 16:06 Bommithi Sakeena
2023-11-28 15:58 ` Rodrigo Vivi
2023-11-02 19:51 Bommithi Sakeena
2023-11-03 3:48 ` Lucas De Marchi
2023-11-03 15:55 ` Rodrigo Vivi
2023-10-11 17:42 Bommithi Sakeena
2023-10-12 9:16 ` Jani Nikula
2023-10-12 14:08 ` Lucas De Marchi
2023-10-12 14:15 ` Jani Nikula
2023-10-13 20:03 ` Rodrigo Vivi
2023-10-13 22:36 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVJ+g0thqwosQbAA@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox