From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "Jouni Högander" <jouni.hogander@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>, intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH v2 0/9] Intel_fbdev.c refactoring
Date: Tue, 14 Nov 2023 13:52:36 -0500 [thread overview]
Message-ID: <ZVPB9NT9cySANtdX@intel.com> (raw)
In-Reply-To: <20231114130443.2503708-1-jouni.hogander@intel.com>
On Tue, Nov 14, 2023 at 03:04:34PM +0200, Jouni Högander wrote:
> This patch set is removing all the ifdefs from intel_fbdev.c. This is
> done by splitting i915 specific code into it's own source file and
> similar source file is created for Xe for Xe specific code.
>
> Remaining ifdefs are dropped by adding some compatibility headers.
>
> Some of the patches are similar as in set from Maarten Lankhorst
> <maarten.lankhorst@linux.intel.com>:
>
> https://patchwork.freedesktop.org/series/126200/
>
> Patches 3 and 9 are supposed to be sent to
> intel-gfx@lists.freedesktop.org. Let's first agree if this is
> acceptable solution from Xe point of view.
>
> v2: Add missing forward declarations into intel_fbdev_fb.h
>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
for the series.
We can push the i915 here as well and after landing in drm-intel-next
we can replace them by the proper cherry-pick -x
>
> Jouni Högander (9):
> Revert "FIXME: drm/i915/display: Allow fbdev to allocate stolen
> memory"
> fixup! FIXME: drm/i915/display: Remaining changes to make xe compile
> drm/i915/display: split i915 specific code from intel_fbdev
> fixup! drm/xe/display: Implement display support
> fixup! drm/xe/display: Implement display support
> fixup! drm/xe/display: Implement display support
> fixup! drm/xe/display: Implement display support
> fixup! drm/xe/display: Implement display support
> drm/i915/display: use intel_bo_to_drm_bo in intel_fbdev
>
> drivers/gpu/drm/i915/Makefile | 3 +-
> drivers/gpu/drm/i915/display/intel_fbdev.c | 203 +-----------------
> drivers/gpu/drm/i915/display/intel_fbdev_fb.c | 116 ++++++++++
> drivers/gpu/drm/i915/display/intel_fbdev_fb.h | 21 ++
> drivers/gpu/drm/xe/Makefile | 1 +
> .../compat-i915-headers/gem/i915_gem_mman.h | 17 ++
> .../compat-i915-headers/gem/i915_gem_object.h | 11 +
> .../gem/i915_gem_object_frontbuffer.h | 4 +-
> .../gpu/drm/xe/compat-i915-headers/i915_drv.h | 2 +
> .../xe/compat-i915-headers/i915_gem_stolen.h | 4 +-
> .../gpu/drm/xe/compat-i915-headers/i915_vma.h | 6 +
> drivers/gpu/drm/xe/display/intel_fbdev_fb.c | 101 +++++++++
> drivers/gpu/drm/xe/display/intel_fbdev_fb.h | 21 ++
> 13 files changed, 312 insertions(+), 198 deletions(-)
> create mode 100644 drivers/gpu/drm/i915/display/intel_fbdev_fb.c
> create mode 100644 drivers/gpu/drm/i915/display/intel_fbdev_fb.h
> create mode 100644 drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_mman.h
> create mode 100644 drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_object.h
> create mode 100644 drivers/gpu/drm/xe/display/intel_fbdev_fb.c
> create mode 100644 drivers/gpu/drm/xe/display/intel_fbdev_fb.h
>
> --
> 2.34.1
>
prev parent reply other threads:[~2023-11-14 18:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 13:04 [Intel-xe] [PATCH v2 0/9] Intel_fbdev.c refactoring Jouni Högander
2023-11-14 13:04 ` [Intel-xe] [PATCH v2 1/9] Revert "FIXME: drm/i915/display: Allow fbdev to allocate stolen memory" Jouni Högander
2023-11-14 13:04 ` [Intel-xe] [PATCH v2 2/9] fixup! FIXME: drm/i915/display: Remaining changes to make xe compile Jouni Högander
2023-11-14 13:04 ` [Intel-xe] [PATCH v2 3/9] drm/i915/display: split i915 specific code from intel_fbdev Jouni Högander
2023-11-14 18:47 ` Rodrigo Vivi
2023-11-15 6:06 ` Hogander, Jouni
2023-11-14 13:04 ` [Intel-xe] [PATCH v2 4/9] fixup! drm/xe/display: Implement display support Jouni Högander
2023-11-14 13:04 ` [Intel-xe] [PATCH v2 5/9] " Jouni Högander
2023-11-14 13:04 ` [Intel-xe] [PATCH v2 6/9] " Jouni Högander
2023-11-14 13:04 ` [Intel-xe] [PATCH v2 7/9] " Jouni Högander
2023-11-14 13:04 ` [Intel-xe] [PATCH v2 8/9] " Jouni Högander
2023-11-14 13:04 ` [Intel-xe] [PATCH v2 9/9] drm/i915/display: use intel_bo_to_drm_bo in intel_fbdev Jouni Högander
2023-11-14 18:49 ` Rodrigo Vivi
2023-11-14 14:29 ` [Intel-xe] ✓ CI.Patch_applied: success for Intel_fbdev.c refactoring (rev2) Patchwork
2023-11-14 14:30 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-11-14 14:31 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-11-14 14:38 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-11-14 14:39 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-11-14 14:40 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-11-14 15:15 ` [Intel-xe] ✗ CI.BAT: failure " Patchwork
2023-11-14 18:52 ` Rodrigo Vivi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVPB9NT9cySANtdX@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jouni.hogander@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox