From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 1/3] drm/xe: Rename xe_gt_idle_sysfs to xe_gt_idle
Date: Tue, 28 Nov 2023 16:31:42 -0500 [thread overview]
Message-ID: <ZWZcPpkeGYOgbc9g@intel.com> (raw)
In-Reply-To: <20231127222236.68999-2-vinay.belgaumkar@intel.com>
On Mon, Nov 27, 2023 at 02:22:34PM -0800, Vinay Belgaumkar wrote:
> Prep this file to contain C6 toggling as well instead
> of just sysfs related stuff.
>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/xe/Makefile | 2 +-
> drivers/gpu/drm/xe/xe_gt.c | 2 +-
> drivers/gpu/drm/xe/{xe_gt_idle_sysfs.c => xe_gt_idle.c} | 4 ++--
> drivers/gpu/drm/xe/{xe_gt_idle_sysfs.h => xe_gt_idle.h} | 8 ++++----
> .../xe/{xe_gt_idle_sysfs_types.h => xe_gt_idle_types.h} | 0
> drivers/gpu/drm/xe/xe_gt_types.h | 2 +-
> 6 files changed, 9 insertions(+), 9 deletions(-)
> rename drivers/gpu/drm/xe/{xe_gt_idle_sysfs.c => xe_gt_idle.c} (98%)
> rename drivers/gpu/drm/xe/{xe_gt_idle_sysfs.h => xe_gt_idle.h} (52%)
> rename drivers/gpu/drm/xe/{xe_gt_idle_sysfs_types.h => xe_gt_idle_types.h} (100%)
>
> diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
> index 551adbc22b5a..18410dd9cb10 100644
> --- a/drivers/gpu/drm/xe/Makefile
> +++ b/drivers/gpu/drm/xe/Makefile
> @@ -61,7 +61,7 @@ xe-y += xe_bb.o \
> xe_gt.o \
> xe_gt_clock.o \
> xe_gt_debugfs.o \
> - xe_gt_idle_sysfs.o \
> + xe_gt_idle.o \
> xe_gt_mcr.o \
> xe_gt_pagefault.o \
> xe_gt_sysfs.o \
> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
> index 0dddb751c6a4..b3686c34477b 100644
> --- a/drivers/gpu/drm/xe/xe_gt.c
> +++ b/drivers/gpu/drm/xe/xe_gt.c
> @@ -22,7 +22,7 @@
> #include "xe_force_wake.h"
> #include "xe_ggtt.h"
> #include "xe_gt_clock.h"
> -#include "xe_gt_idle_sysfs.h"
> +#include "xe_gt_idle.h"
> #include "xe_gt_mcr.h"
> #include "xe_gt_pagefault.h"
> #include "xe_gt_printk.h"
> diff --git a/drivers/gpu/drm/xe/xe_gt_idle_sysfs.c b/drivers/gpu/drm/xe/xe_gt_idle.c
> similarity index 98%
> rename from drivers/gpu/drm/xe/xe_gt_idle_sysfs.c
> rename to drivers/gpu/drm/xe/xe_gt_idle.c
> index 8df9840811cd..e5b7e5d38e76 100644
> --- a/drivers/gpu/drm/xe/xe_gt_idle_sysfs.c
> +++ b/drivers/gpu/drm/xe/xe_gt_idle.c
> @@ -7,14 +7,14 @@
>
> #include "xe_device.h"
> #include "xe_gt.h"
> -#include "xe_gt_idle_sysfs.h"
> +#include "xe_gt_idle.h"
> #include "xe_gt_sysfs.h"
> #include "xe_guc_pc.h"
>
> /**
> * DOC: Xe GT Idle
> *
> - * Provides sysfs entries for idle properties of GT
> + * Contains functions that init GT idle features like C6
> *
> * device/gt#/gtidle/name - name of the state
> * device/gt#/gtidle/idle_residency_ms - Provides residency of the idle state in ms
> diff --git a/drivers/gpu/drm/xe/xe_gt_idle_sysfs.h b/drivers/gpu/drm/xe/xe_gt_idle.h
> similarity index 52%
> rename from drivers/gpu/drm/xe/xe_gt_idle_sysfs.h
> rename to drivers/gpu/drm/xe/xe_gt_idle.h
> index b0973f96c7ab..9b36bf7db3a7 100644
> --- a/drivers/gpu/drm/xe/xe_gt_idle_sysfs.h
> +++ b/drivers/gpu/drm/xe/xe_gt_idle.h
> @@ -3,11 +3,11 @@
> * Copyright © 2023 Intel Corporation
> */
>
> -#ifndef _XE_GT_IDLE_SYSFS_H_
> -#define _XE_GT_IDLE_SYSFS_H_
> +#ifndef _XE_GT_IDLE_H_
> +#define _XE_GT_IDLE_H_
>
> -#include "xe_gt_idle_sysfs_types.h"
> +#include "xe_gt_idle_types.h"
>
> void xe_gt_idle_sysfs_init(struct xe_gt_idle *gtidle);
>
> -#endif /* _XE_GT_IDLE_SYSFS_H_ */
> +#endif /* _XE_GT_IDLE_H_ */
> diff --git a/drivers/gpu/drm/xe/xe_gt_idle_sysfs_types.h b/drivers/gpu/drm/xe/xe_gt_idle_types.h
> similarity index 100%
> rename from drivers/gpu/drm/xe/xe_gt_idle_sysfs_types.h
> rename to drivers/gpu/drm/xe/xe_gt_idle_types.h
> diff --git a/drivers/gpu/drm/xe/xe_gt_types.h b/drivers/gpu/drm/xe/xe_gt_types.h
> index d3f2793684e2..a96ee7d028aa 100644
> --- a/drivers/gpu/drm/xe/xe_gt_types.h
> +++ b/drivers/gpu/drm/xe/xe_gt_types.h
> @@ -7,7 +7,7 @@
> #define _XE_GT_TYPES_H_
>
> #include "xe_force_wake_types.h"
> -#include "xe_gt_idle_sysfs_types.h"
> +#include "xe_gt_idle_types.h"
> #include "xe_hw_engine_types.h"
> #include "xe_hw_fence_types.h"
> #include "xe_reg_sr_types.h"
> --
> 2.38.1
>
next prev parent reply other threads:[~2023-11-28 21:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 22:22 [Intel-xe] [PATCH v4 0/3] drm/xe: Add a flag that can disable GuC PM Vinay Belgaumkar
2023-11-27 22:22 ` [Intel-xe] [PATCH 1/3] drm/xe: Rename xe_gt_idle_sysfs to xe_gt_idle Vinay Belgaumkar
2023-11-28 21:31 ` Rodrigo Vivi [this message]
2023-11-27 22:22 ` [Intel-xe] [PATCH 2/3] drm/xe: Add skip_guc_pc flag Vinay Belgaumkar
2023-11-28 21:32 ` Rodrigo Vivi
2023-11-27 22:22 ` [Intel-xe] [PATCH 3/3] drm/xe: Manually setup C6 when skip_guc_pc is set Vinay Belgaumkar
2023-11-28 21:33 ` Rodrigo Vivi
2023-11-27 22:52 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: Add a flag that can disable GuC PM (rev4) Patchwork
2023-11-27 22:52 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-11-27 22:53 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-11-27 23:00 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-11-27 23:01 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-11-27 23:02 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-11-27 23:37 ` [Intel-xe] ✓ CI.BAT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-11-27 19:58 [Intel-xe] [PATCH v3 0/3] drm/xe: Add a flag that can disable GuC PM Vinay Belgaumkar
2023-11-27 19:58 ` [Intel-xe] [PATCH 1/3] drm/xe: Rename xe_gt_idle_sysfs to xe_gt_idle Vinay Belgaumkar
2023-11-27 18:54 [Intel-xe] [PATCH 0/3] drm/xe: Add a flag that can disable GuC PM Vinay Belgaumkar
2023-11-27 18:54 ` [Intel-xe] [PATCH 1/3] drm/xe: Rename xe_gt_idle_sysfs to xe_gt_idle Vinay Belgaumkar
2023-11-22 21:04 [Intel-xe] [PATCH 0/3] drm/xe: Add a flag that can disable GuC PM Vinay Belgaumkar
2023-11-22 21:04 ` [Intel-xe] [PATCH 1/3] drm/xe: Rename xe_gt_idle_sysfs to xe_gt_idle Vinay Belgaumkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWZcPpkeGYOgbc9g@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox