From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>,
intel-xe@lists.freedesktop.org
Subject: Re: [v3 0/2] Add memory sysfs directory and attributes
Date: Mon, 11 Dec 2023 17:57:09 -0500 [thread overview]
Message-ID: <ZXeTxQzkD6U2T-Gq@intel.com> (raw)
In-Reply-To: <20231211224112.GA1327160@mdroper-desk1.amr.corp.intel.com>
On Mon, Dec 11, 2023 at 02:41:12PM -0800, Matt Roper wrote:
> On Thu, Dec 07, 2023 at 08:47:37PM +0530, Sujaritha Sundaresan wrote:
> > Create another layer of sub directories to clean up memory/vram
> > related sysfs path. Additionally, introduce the vram frequency sysfs
> > under a the new path.
>
> What's the userspace consumer of this uAPI? How will this wind up
> getting used in a real-world software stack? Isn't stuff like the
> memory size already returned via the query interface?
Please notice that this is more for frequency management, nothing related
to the UMD information that we expose in the ioctl queries.
Like every other sysfs interface, it doesn't actually matter what wrapper
ends up using it. In general they are for system administrators to tune
the hardware, so we just need to ensure that it makes sense, it is clean
and something we will be able to maintain long term without breaking
compatibility.
>
>
> Matt
>
> >
> > Sujaritha Sundaresan (2):
> > drm/xe: Add a new memory directory under tile
> > drm/xe: Add vram frequency sysfs attributes
> >
> > drivers/gpu/drm/xe/xe_pcode_api.h | 8 +++
> > drivers/gpu/drm/xe/xe_tile_sysfs.c | 101 +++++++++++++++++++++++++++--
> > 2 files changed, 104 insertions(+), 5 deletions(-)
> >
> > --
> > 2.25.1
> >
>
> --
> Matt Roper
> Graphics Software Engineer
> Linux GPU Platform Enablement
> Intel Corporation
next prev parent reply other threads:[~2023-12-11 22:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 15:17 [v3 0/2] Add memory sysfs directory and attributes Sujaritha Sundaresan
2023-12-07 15:17 ` [v3 1/2] drm/xe: Add a new memory directory under tile Sujaritha Sundaresan
2023-12-08 5:03 ` Upadhyay, Tejas
2023-12-08 8:28 ` Sundaresan, Sujaritha
2023-12-11 9:53 ` Riana Tauro
2023-12-11 10:14 ` Sundaresan, Sujaritha
2023-12-11 11:01 ` Upadhyay, Tejas
2023-12-11 11:07 ` Riana Tauro
2023-12-11 11:13 ` Riana Tauro
2023-12-11 11:41 ` Sundaresan, Sujaritha
2023-12-07 15:17 ` [v3 2/2] drm/xe: Add vram frequency sysfs attributes Sujaritha Sundaresan
2023-12-07 23:11 ` ✓ CI.Patch_applied: success for Add memory sysfs directory and attributes (rev3) Patchwork
2023-12-07 23:11 ` ✗ CI.checkpatch: warning " Patchwork
2023-12-07 23:12 ` ✓ CI.KUnit: success " Patchwork
2023-12-07 23:20 ` ✓ CI.Build: " Patchwork
2023-12-07 23:20 ` ✓ CI.Hooks: " Patchwork
2023-12-07 23:21 ` ✓ CI.checksparse: " Patchwork
2023-12-07 23:57 ` ✓ CI.BAT: " Patchwork
2023-12-11 22:41 ` [v3 0/2] Add memory sysfs directory and attributes Matt Roper
2023-12-11 22:57 ` Rodrigo Vivi [this message]
2023-12-11 23:08 ` Matt Roper
2023-12-12 0:12 ` Vivi, Rodrigo
2023-12-12 3:58 ` Upadhyay, Tejas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXeTxQzkD6U2T-Gq@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
--cc=sujaritha.sundaresan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox