From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE0B7C4332F for ; Thu, 14 Dec 2023 00:57:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C196F10E8A8; Thu, 14 Dec 2023 00:57:12 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 75F8010E8A8 for ; Thu, 14 Dec 2023 00:57:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702515432; x=1734051432; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=mGSJ3yTPSpCRyRq/4sWnQ62gpWQecYbPkPdLx3886wA=; b=n5gpvSzHrpfwbtTauyyHx9p+4gyPTPe5ndLFF9JSKFD2IAlwJg9L7LE8 dBz/ZpZk2ya1/OGDVYYYyEo+5JRhHH3+Zl1ttEEI63NakGvCgmmM/QwUP RwkZ2NHKluSpquoH/iH3/3Y+2HVBJaWgGvoOVRdzwggKUjHptmPblDXu+ HJgrJtEJIdls4/Br9HHgmEYP9ZPTowU1OR5LXWGgB92vAghz5CjvDaw0o uxX+Tsd7D8i2vYpDhhP/p/dJnY3VcCMoQgd8dc2DXyFipClj7b+nxVDII lXIrDNxl89n/M09m2Aw0jGJ6m6zSFcjOG4qDVo61KcNM8OGoJ3ypmqfyI A==; X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="2221863" X-IronPort-AV: E=Sophos;i="6.04,274,1695711600"; d="scan'208";a="2221863" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2023 16:57:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="892233800" X-IronPort-AV: E=Sophos;i="6.04,274,1695711600"; d="scan'208";a="892233800" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Dec 2023 16:57:10 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 13 Dec 2023 16:57:10 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 13 Dec 2023 16:57:10 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 13 Dec 2023 16:57:10 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 13 Dec 2023 16:57:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HuEUQuTPlM90De6f5zFTsXYKHzP63dPNYWEbjJqoFOF3V0CrTwd023blAo5un5qCPgk8VQh2d+M0kXfJET+QmZQYVT0nuIp6L+Dm15uvLt2SVqBIkbpVKUgBX7R+cgNTC57SGNTLQt3XbbzhK3/HXFyF6cnq1e0ZFgkQ9NiPCYIxSIj0MFPrYmX9Y0hoqhqn+mkDjwfgEGP/sB5Q1r7coUeEO90Jn97gkYI6G14u0ZeiOYAGqZOJgUVMfbNEEVnar6z+HV4O2m7njkz+6IG9z1ARbLST002HCKgPatyrHpYlu6Oj4lJyEs7bgqKmscCiLbzUOEVCp+qLaOwpY22z2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=glKW+ZMn40InB7mAEQVysvlxs7xjbAr3dLTmDmRnFmA=; b=MDc8Xg+hyzPCkn96IZi7wz88vv1cYgAH0tPpn40uK4WBaeOye8ZCiU1EignMMEUexlAEUSaW7yJmQzj2oJ+S7UeAtlVkCF5/iSyMvyGQMlay9Wvwf3Dv+gsB2MjVA/3I8SM21Yy6EOUZA9Wot8GdBXd5R/JaSPzD4tQB+oulxfFhsTKrDHZT4nJu6xhtsOMJ7IGyYPDJYcP+YBil9PzBKiLfRW2T1TlmNQDf0lCDFP+6PKwHYhDuJiKiL37B/AI3fzLUU4IufEmxdc+hpCSXa0gw8jsFVKB0TZ8zs/Zq8wFo4ojykPj53iM9qAMtDjBsohvd3WQtXH6rimkUD3Kjdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM6PR11MB2987.namprd11.prod.outlook.com (2603:10b6:5:65::14) by BL1PR11MB5349.namprd11.prod.outlook.com (2603:10b6:208:308::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.28; Thu, 14 Dec 2023 00:57:06 +0000 Received: from DM6PR11MB2987.namprd11.prod.outlook.com ([fe80::e73e:dcc0:c5bb:49b9]) by DM6PR11MB2987.namprd11.prod.outlook.com ([fe80::e73e:dcc0:c5bb:49b9%7]) with mapi id 15.20.7091.028; Thu, 14 Dec 2023 00:57:06 +0000 Date: Wed, 13 Dec 2023 16:57:04 -0800 From: Umesh Nerlige Ramappa To: Ashutosh Dixit Subject: Re: [PATCH 02/17] drm/xe/perf/uapi: Add perf_stream_paranoid sysctl Message-ID: References: <20231208064329.2387604-1-ashutosh.dixit@intel.com> <20231208064329.2387604-3-ashutosh.dixit@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Disposition: inline In-Reply-To: <20231208064329.2387604-3-ashutosh.dixit@intel.com> X-ClientProxiedBy: BY3PR04CA0015.namprd04.prod.outlook.com (2603:10b6:a03:217::20) To DM6PR11MB2987.namprd11.prod.outlook.com (2603:10b6:5:65::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR11MB2987:EE_|BL1PR11MB5349:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a5dc1c9-b695-4e94-a7ce-08dbfc3f977e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XxcOgxRdReLH6j2poMgIB95PyhMmtmPW3Da4/vbC6BXsxUU109kqh3WewgqFkhTK0ESMmgAsbnunBHwYGaJeKjsKMXsHXQ5TJ6x1GBCfVdzmC6fi0ukY+wGZAK0tE9qWn+UK5+8Gfz1op37WMMVp46OaCaYJuNTHeU4XEsNVg0rmNy8dYrlROaYmToOpdNPZhWuE1CMSlhlAduabzlfydPegwz6k0E13in0Td8e6puXzWBWJpoONsvj9CcOzTjQhPPulRMPix7xAO5fyWeHO90PuLo4bCNHbA98A+VjTy8RdJi4qzwrsLlb4MOMSCSzrJHUTlMRDocBK18dsYdNgimtPnad8On1MyXvmg2x9vpTkudZAM7zMDHA9au7XJ+t1fbLCjyXXnD97OdMegxP3ukdReShbgq5S/yUGqsaXJd/F/FKjFEFdAdM/uCatc44eFekj4l8XvE+bBz9yc6u0noDwByUiQUTAzAuuGFQ5BrE5h96kmbyznc8qZO+TLP4NdMYbX9vXplRsDCh/3SBtwnGw6AZ/BSqlR9KnINKlYb1Tz7Gp0K5MR1jPhRMaRgummsdo4dYYg03rjmQzp67j5mRIBTZKyyMg4XsDgq4U93c= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2987.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(7916004)(136003)(39860400002)(366004)(376002)(396003)(346002)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(9686003)(6506007)(6512007)(6486002)(478600001)(83380400001)(26005)(2906002)(5660300002)(41300700001)(316002)(6636002)(66556008)(66946007)(66476007)(33716001)(4326008)(6862004)(8936002)(8676002)(82960400001)(86362001)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azh2c3BJd00vaFhpaVJnbzBkdGRGbHpaYk1zY1VrdjVkeUlwY0RRUzF2dG82?= =?utf-8?B?OTdOMFRJZHdiMFM5M3AvN3dUdHNsbHZzOCtHRWk1bjlNS2duemJWeW5Fbi9D?= =?utf-8?B?RWEvZjlmRGdZZmRNUWd2UTN3T0NRREtUM3U4djRtclppOE5iVytyNUVKU1Zh?= =?utf-8?B?VnNQb0t0NXFYSTFJY09ZaUs5SXhBZE92dTgrQ1NoNVRiT25uTVdiZ2NaaFNS?= =?utf-8?B?cG41a09LbzFoNWhHS2N1SUFFMDl3N3prbnVpNWZwc3BEdXZuVXNoWlZQK09P?= =?utf-8?B?UU5aZS9LdE1lYnpZN3FxUW0wR2U0bXFNUktYdjhGUkh4bmcwNm1PUHZLZ3J4?= =?utf-8?B?UnExa2w5a0hQd2dXY2s3NklqQVN5WXF6V1R5L1QzL0VGYmVCdkQyTFIyOHBH?= =?utf-8?B?RDB6Tldhd3FCN016NE0rSXh6ZjlZcGk3SlVnajVyZ2NMaHJ4Q0lQb1dRYzdn?= =?utf-8?B?ejBiOWNvM0ZXZWNyQjB2aWZlVTV0Rm5JTDd2aGx0SDE5NUF2eHRUNEZ4cTlX?= =?utf-8?B?SC84bFAyaGJrUjlWM0pjdnByaFBZQ1JvMlFqak9nd3BXdk1PVG83K3Via09z?= =?utf-8?B?UW5RTEIxOExDVUZLY3F0cC9DMXVJNlQ3c3Y1Z09qNllQMGRURVdCVjBadG04?= =?utf-8?B?eGhHWVBmSS9kY0E3RWorY0NjT2RzZitLY0hFaFhDMjEvRzk0ZCt5MC9Ua2JN?= =?utf-8?B?MTRtTllKdm9qRWZNL28xNVQ4eUgrVUhjRTJ3TUZEbnR3V0xnU0N4cWg2anNM?= =?utf-8?B?UUp6WENrNGdaUEtpT2srbkt0K0NYc1M1MEZWU3lnRUhKV1V2Z0N5NnFUTEtl?= =?utf-8?B?V1F1UEZ5TFpNejA1VDZGUXh1WWY2bjMzajJWVENIWkRBRDhvTW9GR2orOEtC?= =?utf-8?B?MG1KQkg4R0dBZk41Si9YZkZxcG44dUtITndQR0oyTFh4d0hnODdic2o2ODZk?= =?utf-8?B?VHBGUWhYTGM4OWs1Q0RqRW5idDN1YXdPa1AzNEgrQ1RDdm5zZWZyaHAvSlJC?= =?utf-8?B?L3V0K3IvQk1iVGp2RjBBcWx2RW5FM1FWVE5wMHhyamNXWTFaNVZ5OUJxR0N2?= =?utf-8?B?b01MUGV6ZkZ1V1Z6VEpvQ0pwNEV1Z0xNR1Q4ZVBPNndLdmtKdFRDaTgvNjBk?= =?utf-8?B?VVE2QS9IOW54Y2RGRjU4RkxpNExmMXh5VlY3aDFpQTlhNnVwUGE5NEJUN3VC?= =?utf-8?B?TnpBcHVtQTV2N1pEcUV5djV0Sk05MTFHT2Exbk5uU0dhd3p3VmlaeHAzSmM3?= =?utf-8?B?NFRBNE1FeTF4UEJFcDVLZjhXT3RWZWQzeGR2V01EZEQ0a04vb2x4TUJUWE5C?= =?utf-8?B?MUU4akJoZU1Xak9oSHZyZHdkWnI5WTNuTXczUUlxSkdTZ25rN0Y3emlGSzhV?= =?utf-8?B?UmNFRUk2Z015YytlMUhGRjVuenZZL0F2UFNSU3NCcms3NUpkVVd3TnNPNk9O?= =?utf-8?B?N2g4eVdhbmNmU0lZR2srN29RVWpmalk5OXBtVFhrL2djZG9vZEw5QWVhbjN0?= =?utf-8?B?UDBxMmlObnZ5UW5YWmJiUTZQZzVkQ1R4b29IZ0YrMTFxODE0TlFNOVpnNVhM?= =?utf-8?B?aWpTS01Kb09YbkwxWU1sbXJITXRTcFVIaXo4aU5JckUwV0hPaXNtQ1lTcHVs?= =?utf-8?B?ZHNYZWpqRHBadS9nTURIV1oxbkxQd0psV0ZkY2RyMGt6UmlaME5HWVpKeUZF?= =?utf-8?B?R0p4bFhHWVFwcUxWQ1lkTUQyWXFLZU8ydTZ6a3hURGVTblVEdktYejVrQ2E2?= =?utf-8?B?V1N5eEF6eTd6TUJRaWdqZ1Y4RGtYVXZqWHJQbEs2ZFlaUVZBRXd3Q2hqZjhR?= =?utf-8?B?UXJCT2h3c2Z5ZW1aaGh3L3JVcmNHSERQc2t3Q0tyamZPeUpGMytic1BiMUFv?= =?utf-8?B?MVRFaG42VngrOXUzVVZ6Wk9NVW9SSSs3NjFwb2pyWDg1RTc2bUFxWTg3R25i?= =?utf-8?B?cjF5VzRtMWRRcXVDdkxqeWQzVmRObGpxaTRDcmFwem9lTmI2ZHVZbi8zTjJD?= =?utf-8?B?ZUdGblRIMW1rV0FFblBGMjVTSzRLY3ZpS1BFeXdkbVdzcEI5Ui94b3VmYWxL?= =?utf-8?B?ZUczaEQrZ0Mrd3BheGRSQW5lSHcvQmdLc0VLaXFEY3VBMHlOa2gxZ3pFYW8v?= =?utf-8?B?V3p2VXFmdndVZDF1SDE3ZlpNYlMxNDVLMnRVckJpUSthbm9lODFnMWp5NE5L?= =?utf-8?Q?xlbWF7gSsgeGqnMAtrNoEes=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1a5dc1c9-b695-4e94-a7ce-08dbfc3f977e X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2987.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 00:57:05.9820 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: epDkggDw6MjLClu4owxpLBtgjLFaVLfakwwf1FhbGsxYBKn68+do3dGWr5B/ZB/NnSd1kjL4rjpVN4ZkqtyWRlsFT4NkRGg/jQotrm2Q2Us= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5349 X-OriginatorOrg: intel.com X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-xe@lists.freedesktop.org Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, Dec 07, 2023 at 10:43:14PM -0800, Ashutosh Dixit wrote: >Normally only superuser/root can access perf counter data. However, >superuser can set perf_stream_paranoid sysctl to 0 to allow non-privileged >users to also access perf data. perf_stream_paranoid is introduced at the >perf layer to allow different perf stream types to share this access >mechanism. > >Signed-off-by: Ashutosh Dixit lgtm, Reviewed-by: Umesh Nerlige Ramappa >--- > drivers/gpu/drm/xe/xe_module.c | 5 +++++ > drivers/gpu/drm/xe/xe_perf.c | 28 ++++++++++++++++++++++++++++ > drivers/gpu/drm/xe/xe_perf.h | 4 ++++ > 3 files changed, 37 insertions(+) > >diff --git a/drivers/gpu/drm/xe/xe_module.c b/drivers/gpu/drm/xe/xe_module.c >index 51bf69b7ab222..8629330d928b0 100644 >--- a/drivers/gpu/drm/xe/xe_module.c >+++ b/drivers/gpu/drm/xe/xe_module.c >@@ -11,6 +11,7 @@ > #include "xe_drv.h" > #include "xe_hw_fence.h" > #include "xe_pci.h" >+#include "xe_perf.h" > #include "xe_pmu.h" > #include "xe_sched_job.h" > >@@ -71,6 +72,10 @@ static const struct init_funcs init_funcs[] = { > .init = xe_register_pci_driver, > .exit = xe_unregister_pci_driver, > }, >+ { >+ .init = xe_perf_sysctl_register, >+ .exit = xe_perf_sysctl_unregister, >+ }, > }; > > static int __init xe_init(void) >diff --git a/drivers/gpu/drm/xe/xe_perf.c b/drivers/gpu/drm/xe/xe_perf.c >index a130076b59aa2..37538e98dcc04 100644 >--- a/drivers/gpu/drm/xe/xe_perf.c >+++ b/drivers/gpu/drm/xe/xe_perf.c >@@ -4,9 +4,13 @@ > */ > > #include >+#include > > #include "xe_perf.h" > >+u32 xe_perf_stream_paranoid = true; >+static struct ctl_table_header *sysctl_header; >+ > int xe_perf_ioctl(struct drm_device *dev, void *data, struct drm_file *file) > { > struct drm_xe_perf_param *arg = data; >@@ -19,3 +23,27 @@ int xe_perf_ioctl(struct drm_device *dev, void *data, struct drm_file *file) > return -EINVAL; > } > } >+ >+static struct ctl_table perf_ctl_table[] = { >+ { >+ .procname = "perf_stream_paranoid", >+ .data = &xe_perf_stream_paranoid, >+ .maxlen = sizeof(xe_perf_stream_paranoid), >+ .mode = 0644, >+ .proc_handler = proc_dointvec_minmax, >+ .extra1 = SYSCTL_ZERO, >+ .extra2 = SYSCTL_ONE, >+ }, >+ {} >+}; >+ >+int xe_perf_sysctl_register(void) >+{ >+ sysctl_header = register_sysctl("dev/xe", perf_ctl_table); >+ return 0; >+} >+ >+void xe_perf_sysctl_unregister(void) >+{ >+ unregister_sysctl_table(sysctl_header); >+} >diff --git a/drivers/gpu/drm/xe/xe_perf.h b/drivers/gpu/drm/xe/xe_perf.h >index 254cc7cf49fef..1ff0a07ebab30 100644 >--- a/drivers/gpu/drm/xe/xe_perf.h >+++ b/drivers/gpu/drm/xe/xe_perf.h >@@ -11,6 +11,10 @@ > struct drm_device; > struct drm_file; > >+extern u32 xe_perf_stream_paranoid; >+ > int xe_perf_ioctl(struct drm_device *dev, void *data, struct drm_file *file); >+int xe_perf_sysctl_register(void); >+void xe_perf_sysctl_unregister(void); > > #endif >-- >2.41.0 >