Re: [PATCH v2 1/3] drm/xe: Remove ci-only GuC FW definitions

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Tue, Dec 19, 2023 at 12:00:20PM -0800, Daniele Ceraolo Spurio wrote:
> As part of the FW definitions, we declare each blob as required via the
> MODULE_FIRMWARE() macro. This causes the initramfs update (or equivalent
> process) to look for the blobs on disk when the kernel is installed;
> therefore, we need to make sure that all FWs we define are available in
> linux-firmware.
> 
> We currently don't plan to push the PVC blob to linux-firmware, while the
> LNL one will only be pushed once we have machines in CI to test it, so we
> need to remove them from the list for now.
> 
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>

For the series:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

and including it right now as part a respin for the pull-request

> ---
> 
> This patch is intended to be added to the PR sent for drm-next, with the
> FW definitions being added to topic/core-for-CI afterwards by the other
> patches in this series.
> 
> Note that this patch remove the last uses of the mmp FWs, but the
> support for those has been left in because we do plan to use mmp tags
> for early FW drops in the CI branch.
> 
>  drivers/gpu/drm/xe/xe_uc_fw.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_uc_fw.c b/drivers/gpu/drm/xe/xe_uc_fw.c
> index 73d6938c921d..9dff96dfe455 100644
> --- a/drivers/gpu/drm/xe/xe_uc_fw.c
> +++ b/drivers/gpu/drm/xe/xe_uc_fw.c
> @@ -102,9 +102,7 @@ struct fw_blobs_by_type {
>  };
>  
>  #define XE_GUC_FIRMWARE_DEFS(fw_def, mmp_ver, major_ver)			\
> -	fw_def(LUNARLAKE,	mmp_ver(xe,	guc,	lnl,	70, 6, 8))	\
>  	fw_def(METEORLAKE,	major_ver(i915,	guc,	mtl,	70, 7))		\
> -	fw_def(PVC,		mmp_ver(xe,	guc,	pvc,	70, 9, 1))	\
>  	fw_def(DG2,		major_ver(i915,	guc,	dg2,	70, 5))		\
>  	fw_def(DG1,		major_ver(i915,	guc,	dg1,	70, 5))		\
>  	fw_def(ALDERLAKE_N,	major_ver(i915,	guc,	tgl,	70, 5))		\
> -- 
> 2.43.0
>