Re: [PATCH 1/2] drm/xe: Fix guc_exec_queue_set_priority

[Matthew Brost <matthew.brost@intel.com>]

On Fri, Jan 05, 2024 at 11:04:39AM -0800, Brian Welty wrote:
> We need to set q->priority prior to calling guc_exec_queue_add_msg() as
> that will call init_policies() and sets the scheduling properties to those
> stored in the exec_queue.
> 
> Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
> Signed-off-by: Brian Welty <brian.welty@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 21ac68e3246f..5de3ac47c462 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -1308,8 +1308,8 @@ static int guc_exec_queue_set_priority(struct xe_exec_queue *q,
>  	if (!msg)
>  		return -ENOMEM;
>  
> -	guc_exec_queue_add_msg(q, msg, SET_SCHED_PROPS);
>  	q->priority = priority;
> +	guc_exec_queue_add_msg(q, msg, SET_SCHED_PROPS);
>  
>  	return 0;
>  }
> -- 
> 2.43.0
>