Re: [PATCH 1/4] drm/xe/guc: Move GUC_ID_MAX definition to GuC ABI header

[Matthew Brost <matthew.brost@intel.com>]

On Wed, Jan 10, 2024 at 06:46:19PM +0100, Michal Wajdeczko wrote:
> This macro represents GuC firmware capability and shall be defined
> in the firmware ABI header. Move it to xe_guc_fwif.h file.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_guc_fwif.h   | 2 ++
>  drivers/gpu/drm/xe/xe_guc_submit.c | 1 -
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_fwif.h b/drivers/gpu/drm/xe/xe_guc_fwif.h
> index 4dd5a88a7826..949aaf04be42 100644
> --- a/drivers/gpu/drm/xe/xe_guc_fwif.h
> +++ b/drivers/gpu/drm/xe/xe_guc_fwif.h
> @@ -14,6 +14,8 @@
>  #define G2H_LEN_DW_DEREGISTER_CONTEXT		3
>  #define G2H_LEN_DW_TLB_INVALIDATE		3
>  
> +#define GUC_ID_MAX			65535
> +
>  #define GUC_CONTEXT_DISABLE		0
>  #define GUC_CONTEXT_ENABLE		1
>  
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 54ffcfcdd41f..022e93796bf8 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -241,7 +241,6 @@ static void guc_submit_fini(struct drm_device *drm, void *arg)
>  	mutex_destroy(&guc->submission_state.lock);
>  }
>  
> -#define GUC_ID_MAX		65535
>  #define GUC_ID_NUMBER_MLRC	4096
>  #define GUC_ID_NUMBER_SLRC	(GUC_ID_MAX - GUC_ID_NUMBER_MLRC)
>  #define GUC_ID_START_MLRC	GUC_ID_NUMBER_SLRC
> -- 
> 2.25.1
>