Re: [PATCH] drm/xe: Use kstrdup while creating snapshot

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Jan 12, 2024 at 05:06:52PM +0100, Michal Wajdeczko wrote:
> There is no need to copy string step by step, use existing helper.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_hw_engine.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c b/drivers/gpu/drm/xe/xe_hw_engine.c
> index e279ef6c527c..3aaab507f37f 100644
> --- a/drivers/gpu/drm/xe/xe_hw_engine.c
> +++ b/drivers/gpu/drm/xe/xe_hw_engine.c
> @@ -749,7 +749,6 @@ struct xe_hw_engine_snapshot *
>  xe_hw_engine_snapshot_capture(struct xe_hw_engine *hwe)
>  {
>  	struct xe_hw_engine_snapshot *snapshot;
> -	int len;
>  
>  	if (!xe_hw_engine_is_valid(hwe))
>  		return NULL;
> @@ -759,11 +758,7 @@ xe_hw_engine_snapshot_capture(struct xe_hw_engine *hwe)
>  	if (!snapshot)
>  		return NULL;
>  
> -	len = strlen(hwe->name) + 1;
> -	snapshot->name = kzalloc(len, GFP_ATOMIC);
> -	if (snapshot->name)
> -		strscpy(snapshot->name, hwe->name, len);
> -
> +	snapshot->name = kstrdup(hwe->name, GFP_ATOMIC);
>  	snapshot->class = hwe->class;
>  	snapshot->logical_instance = hwe->logical_instance;
>  	snapshot->forcewake.domain = hwe->domain;
> 
> base-commit: 7a20187068bed91b523795a18219e570f1e84eb1
> -- 
> 2.25.1
>