From: Francois Dugast <francois.dugast@intel.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: intel-xe@lists.freedesktop.org, Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 5/5] drm/xe: Use a NULL pointer instead of 0.
Date: Wed, 17 Jan 2024 14:59:29 +0100 [thread overview]
Message-ID: <ZafdQTbd0XQFlsTo@fdugast-desk.home> (raw)
In-Reply-To: <20240117134048.165425-6-thomas.hellstrom@linux.intel.com>
On Wed, Jan 17, 2024 at 02:40:48PM +0100, Thomas Hellström wrote:
> The last argument of xe_pcode_read() is a pointer. Use NULL instead of 0.
>
> Fixes: 92d44a422d0d ("drm/xe/hwmon: Expose card reactive critical power")
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Francois Dugast <francois.dugast@intel.com>
> ---
> drivers/gpu/drm/xe/xe_hwmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index 6ef2aa1eae8b..174ed2185481 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> @@ -419,7 +419,7 @@ static int xe_hwmon_pcode_read_i1(struct xe_gt *gt, u32 *uval)
>
> return xe_pcode_read(gt, PCODE_MBOX(PCODE_POWER_SETUP,
> POWER_SETUP_SUBCOMMAND_READ_I1, 0),
> - uval, 0);
> + uval, NULL);
> }
>
> static int xe_hwmon_pcode_write_i1(struct xe_gt *gt, u32 uval)
> --
> 2.43.0
>
next prev parent reply other threads:[~2024-01-17 13:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 13:40 [PATCH 0/5] Fixes for sparse warning Thomas Hellström
2024-01-17 13:40 ` [PATCH 1/5] drm/xe/dmabuf: Make xe_dmabuf_ops static Thomas Hellström
2024-01-17 13:48 ` Francois Dugast
2024-01-17 13:40 ` [PATCH 2/5] drm/xe/ggtt: Use ioread64 to dereference ggtt::gsm Thomas Hellström
2024-01-30 17:11 ` Matthew Brost
2024-01-17 13:40 ` [PATCH 3/5] drm/xe: Annotate mcr_[un]lock() Thomas Hellström
2024-01-30 17:18 ` Matthew Brost
2024-01-17 13:40 ` [PATCH 4/5] drm/xe: Don't use __user error pointers Thomas Hellström
2024-01-30 17:54 ` Matthew Brost
2024-01-17 13:40 ` [PATCH 5/5] drm/xe: Use a NULL pointer instead of 0 Thomas Hellström
2024-01-17 13:59 ` Francois Dugast [this message]
2024-01-17 23:12 ` ✓ CI.Patch_applied: success for Fixes for sparse warning Patchwork
2024-01-17 23:12 ` ✗ CI.checkpatch: warning " Patchwork
2024-01-17 23:13 ` ✓ CI.KUnit: success " Patchwork
2024-01-17 23:21 ` ✓ CI.Build: " Patchwork
2024-01-17 23:21 ` ✓ CI.Hooks: " Patchwork
2024-01-17 23:22 ` ✓ CI.checksparse: " Patchwork
2024-01-17 23:46 ` ✓ CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZafdQTbd0XQFlsTo@fdugast-desk.home \
--to=francois.dugast@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox