From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9AFDC47258 for ; Wed, 31 Jan 2024 09:16:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8951A113ACE; Wed, 31 Jan 2024 09:16:07 +0000 (UTC) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1A1BB113ACF for ; Wed, 31 Jan 2024 09:16:06 +0000 (UTC) Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a28cfca3c45so121913766b.1 for ; Wed, 31 Jan 2024 01:16:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1706692504; x=1707297304; darn=lists.freedesktop.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=6mJ/VC9yB8SBaqaP6I7gLNaUO/QsMoAzNYJiR3/6bAw=; b=aIb60uQjip4QB7hgFY/U5T1DhEkjIP7F0w/wjGqAyk/xp0Fkf7P/N6ani0a4+ygOOL lnKpz9WMA9kYMm1Jq95WolopGUKwJmjjZsEj5As9apI6MTFE5lJPea2GdppeAOecDTAN KfcdV4byCEy58HVchX/f+wcLlao0FB8R3s4Es= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706692504; x=1707297304; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6mJ/VC9yB8SBaqaP6I7gLNaUO/QsMoAzNYJiR3/6bAw=; b=A3WO9DGbrC4Yd5zsjTRWd2GdyG13YZ0JqaUZ2OeS0Xn33NQ9sLZEcY9h2bG+lo0L4A WIBeLJXUWJzDJr/WczleWFlOka3zeTU6SjSLPZI02Rh9VV3RdSa4g8QV0AjvfWMjqbe7 awQSPcRHxPq1exyvQ/Z8lAdbUYIAGpWj0NENdxdG725jJc4cCwq/kWQc9bDk49E04Lia FXKfT2xD8uBqkguqa3BmUSs2f7YdQlJ8lO/RddfoMDxh0Eh0JuK1hFKHEJLiTRCuG/On FtyvYzaz7sbFeOPXlmaLC5UfFqlnd42zYq07mZ72to/yIWn6C7sCbVYVGYWNULRLiRBZ EZBA== X-Forwarded-Encrypted: i=0; AJvYcCXQh3OVicmQh7hFuFWMgb6YejPMQOa+roZ6fcLeT7d2YpKmB5faMCGrzBC3RDMKKqf6EWjQo4NEUZPQvpN1ko+unPy2LJzluXlpOlxFVkc= X-Gm-Message-State: AOJu0Ywuh+wihAGmf5ROaCH9WXqmWRkbe8bT5jloUS5382BHdMYooBTf MXISsL7hpighM+PZnbi/LjioZB/QidGhOC7sPEIGsQhOnDbVegLZcKVOu4jpZR8= X-Google-Smtp-Source: AGHT+IEpGYUbEZmfc8oKpOHviV0+VBBnFeRII3w1qPcAaRRwXKG9iHVOTwh6mCfk9k8HhwirjVOT7Q== X-Received: by 2002:a17:906:1853:b0:a2f:ded9:dc76 with SMTP id w19-20020a170906185300b00a2fded9dc76mr587121eje.7.1706692504462; Wed, 31 Jan 2024 01:15:04 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id g14-20020a170906394e00b00a2ccddf9a7dsm5960859eje.124.2024.01.31.01.15.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 01:15:03 -0800 (PST) Date: Wed, 31 Jan 2024 10:15:01 +0100 From: Daniel Vetter To: David Airlie Subject: Re: Making drm_gpuvm work across gpu devices Message-ID: References: <7834e2fbe8052717a4e0fa44feafa544b1fedaa0.camel@linux.intel.com> <851e3ddb-6c74-4ec5-8d05-df12b34eb2b4@amd.com> <5aca8bdc-1243-40e6-90dc-ece80a093a5b@amd.com> <801c3357-d49b-4505-a1a4-ef2f36ba63e0@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: Linux phenom 6.6.11-amd64 X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "rcampbell@nvidia.com" , "apopple@nvidia.com" , Felix Kuehling , "Shah, Ankur N" , "intel-xe@lists.freedesktop.org" , "jglisse@redhat.com" , "dri-devel@lists.freedesktop.org" , Daniel Vetter , Christian =?iso-8859-1?Q?K=F6nig?= , Danilo Krummrich Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, Jan 31, 2024 at 09:12:39AM +1000, David Airlie wrote: > On Wed, Jan 31, 2024 at 8:29 AM Zeng, Oak wrote: > > > > Hi Christian, > > > > > > > > Nvidia Nouveau driver uses exactly the same concept of SVM with HMM, GPU address in the same process is exactly the same with CPU virtual address. It is already in upstream Linux kernel. We Intel just follow the same direction for our customers. Why we are not allowed? > > > Oak, this isn't how upstream works, you don't get to appeal to > customer or internal design. nouveau isn't "NVIDIA"'s and it certainly > isn't something NVIDIA would ever suggest for their customers. We also > likely wouldn't just accept NVIDIA's current solution upstream without > some serious discussions. The implementation in nouveau was more of a > sample HMM use case rather than a serious implementation. I suspect if > we do get down the road of making nouveau an actual compute driver for > SVM etc then it would have to severely change. Yeah on the nouveau hmm code specifically my gut feeling impression is that we didn't really make friends with that among core kernel maintainers. It's a bit too much just a tech demo to be able to merge the hmm core apis for nvidia's out-of-tree driver. Also, a few years of learning and experience gaining happened meanwhile - you always have to look at an api design in the context of when it was designed, and that context changes all the time. Cheers, Sima -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch