Re: [PATCH] drm/xe: Remove exec queue bind.fence_*

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, Feb 12, 2024 at 08:32:51PM -0800, Matthew Brost wrote:
> struct xe_exec_queue bind.fence_* members are unused. Remove these.
> 
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>

trusting more your compiler then my greps:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_exec_queue.c       |  4 ----
>  drivers/gpu/drm/xe/xe_exec_queue_types.h | 29 ++++++++----------------
>  2 files changed, 9 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c b/drivers/gpu/drm/xe/xe_exec_queue.c
> index 2976635be4d3..da84ac93a559 100644
> --- a/drivers/gpu/drm/xe/xe_exec_queue.c
> +++ b/drivers/gpu/drm/xe/xe_exec_queue.c
> @@ -94,10 +94,6 @@ static struct xe_exec_queue *__xe_exec_queue_alloc(struct xe_device *xe,
>  		q->parallel.composite_fence_ctx = dma_fence_context_alloc(1);
>  		q->parallel.composite_fence_seqno = XE_FENCE_INITIAL_SEQNO;
>  	}
> -	if (q->flags & EXEC_QUEUE_FLAG_VM) {
> -		q->bind.fence_ctx = dma_fence_context_alloc(1);
> -		q->bind.fence_seqno = XE_FENCE_INITIAL_SEQNO;
> -	}
>  
>  	return q;
>  }
> diff --git a/drivers/gpu/drm/xe/xe_exec_queue_types.h b/drivers/gpu/drm/xe/xe_exec_queue_types.h
> index 648391961fc4..3df8571e4a07 100644
> --- a/drivers/gpu/drm/xe/xe_exec_queue_types.h
> +++ b/drivers/gpu/drm/xe/xe_exec_queue_types.h
> @@ -115,26 +115,15 @@ struct xe_exec_queue {
>  		struct list_head link;
>  	} persistent;
>  
> -	union {
> -		/**
> -		 * @parallel: parallel submission state
> -		 */
> -		struct {
> -			/** @parallel.composite_fence_ctx: context composite fence */
> -			u64 composite_fence_ctx;
> -			/** @parallel.composite_fence_seqno: seqno for composite fence */
> -			u32 composite_fence_seqno;
> -		} parallel;
> -		/**
> -		 * @bind: bind submission state
> -		 */
> -		struct {
> -			/** @bind.fence_ctx: context bind fence */
> -			u64 fence_ctx;
> -			/** @bind.fence_seqno: seqno for bind fence */
> -			u32 fence_seqno;
> -		} bind;
> -	};
> +	/**
> +	 * @parallel: parallel submission state
> +	 */
> +	struct {
> +		/** @parallel.composite_fence_ctx: context composite fence */
> +		u64 composite_fence_ctx;
> +		/** @parallel.composite_fence_seqno: seqno for composite fence */
> +		u32 composite_fence_seqno;
> +	} parallel;
>  
>  	/** @sched_props: scheduling properties */
>  	struct {
> -- 
> 2.34.1
>