Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <ruthuvikas.ravikumar@intel.com>
Subject: Re: [PATCH] drm/xe: Fix modpost warning on xe_mocs kunit module
Date: Tue, 13 Feb 2024 10:27:22 -0500	[thread overview]
Message-ID: <ZcuKWlUMIEZV_vQ6@intel.com> (raw)
In-Reply-To: <20240213033548.76219-1-ashutosh.dixit@intel.com>

On Mon, Feb 12, 2024 at 07:35:48PM -0800, Ashutosh Dixit wrote:
> $ make W=1 -j100 M=drivers/gpu/drm/xe
> MODPOST drivers/gpu/drm/xe/Module.symvers
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/xe/tests/xe_mocs_test.o
> 
> Fix is identical to '1d425066f15f ("drm/xe: Fix modpost warning on kunit
> modules")'.

I don't see this widely used in the kernel, but since this style
is already in Xe, and this is fixing the warning, let's move fwd.

Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> 
> Fixes: a6a4ea6d7d37 ("drm/xe: Add mocs kunit")
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
>  drivers/gpu/drm/xe/tests/xe_mocs_test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/xe/tests/xe_mocs_test.c b/drivers/gpu/drm/xe/tests/xe_mocs_test.c
> index 4f62e7a4270bd..ee40f31e1e12c 100644
> --- a/drivers/gpu/drm/xe/tests/xe_mocs_test.c
> +++ b/drivers/gpu/drm/xe/tests/xe_mocs_test.c
> @@ -22,4 +22,5 @@ kunit_test_suite(xe_mocs_test_suite);
>  
>  MODULE_AUTHOR("Intel Corporation");
>  MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("xe_mocs kunit test");
>  MODULE_IMPORT_NS(EXPORTED_FOR_KUNIT_TESTING);
> -- 
> 2.41.0
> 

      parent reply	other threads:[~2024-02-13 15:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-13  3:35 [PATCH] drm/xe: Fix modpost warning on xe_mocs kunit module Ashutosh Dixit
2024-02-13  3:38 ` ✓ CI.Patch_applied: success for " Patchwork
2024-02-13  3:38 ` ✗ CI.checkpatch: warning " Patchwork
2024-02-13  3:39 ` ✓ CI.KUnit: success " Patchwork
2024-02-13  3:50 ` ✓ CI.Build: " Patchwork
2024-02-13  3:50 ` ✓ CI.Hooks: " Patchwork
2024-02-13  3:52 ` ✓ CI.checksparse: " Patchwork
2024-02-13  4:28 ` ✓ CI.BAT: " Patchwork
2024-02-13 15:27 ` Rodrigo Vivi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZcuKWlUMIEZV_vQ6@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=ashutosh.dixit@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=ruthuvikas.ravikumar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox