From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: intel-xe@lists.freedesktop.org,
"Michał Winiarski" <michal.winiarski@intel.com>
Subject: Re: [PATCH 3/3] drm/xe/pf: Always use Multi-Level LMTT for newer platforms
Date: Tue, 13 Feb 2024 17:30:56 -0500 [thread overview]
Message-ID: <ZcvtoATYo1CiTTHG@intel.com> (raw)
In-Reply-To: <20240213212418.1309-4-michal.wajdeczko@intel.com>
On Tue, Feb 13, 2024 at 10:24:18PM +0100, Michal Wajdeczko wrote:
> Change function logic to prefer Multi-Level LMTT variant on all
> new platforms.
>
> Bspec: 52404, 67468
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Michał Winiarski <michal.winiarski@intel.com>
> ---
> drivers/gpu/drm/xe/xe_lmtt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_lmtt.c b/drivers/gpu/drm/xe/xe_lmtt.c
> index dfb0e1887615..ac77e9507f07 100644
> --- a/drivers/gpu/drm/xe/xe_lmtt.c
> +++ b/drivers/gpu/drm/xe/xe_lmtt.c
> @@ -35,7 +35,7 @@
>
> static bool xe_has_multi_level_lmtt(struct xe_device *xe)
> {
> - return xe->info.platform == XE_PVC;
> + return xe->info.platform >= XE_PVC;
We should use GRAPHICS_VER(xe) for greater-then checks and
limit the platform only for specific cases (== only).
> }
>
> static struct xe_tile *lmtt_to_tile(struct xe_lmtt *lmtt)
> --
> 2.43.0
>
next prev parent reply other threads:[~2024-02-13 22:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 21:24 [PATCH 0/3] LMTT improvements Michal Wajdeczko
2024-02-13 21:24 ` [PATCH 1/3] drm/xe: Allow vram bo allocations aligned to 64K Michal Wajdeczko
2024-02-13 22:28 ` Rodrigo Vivi
2024-02-13 21:24 ` [PATCH 2/3] drm/xe/pf: Request 64K aligned allocations for LMTT PD Michal Wajdeczko
2024-02-13 22:27 ` Rodrigo Vivi
2024-02-13 21:24 ` [PATCH 3/3] drm/xe/pf: Always use Multi-Level LMTT for newer platforms Michal Wajdeczko
2024-02-13 22:30 ` Rodrigo Vivi [this message]
2024-02-13 22:23 ` ✓ CI.Patch_applied: success for LMTT improvements Patchwork
2024-02-13 22:23 ` ✓ CI.checkpatch: " Patchwork
2024-02-13 22:24 ` ✓ CI.KUnit: " Patchwork
2024-02-13 22:35 ` ✓ CI.Build: " Patchwork
2024-02-13 22:35 ` ✓ CI.Hooks: " Patchwork
2024-02-13 22:37 ` ✓ CI.checksparse: " Patchwork
2024-02-13 22:59 ` ✓ CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcvtoATYo1CiTTHG@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
--cc=michal.winiarski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox