Re: [PATCH] drm/xe: Fix cast on trace variable again

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Feb 20, 2024 at 12:56:07PM -0800, Lucas De Marchi wrote:
> Same fix as commit 8d038f49c1f3 ("drm/xe: Fix cast on trace variable")
> that has been inadvertently reverted by a later commit.
> 
> Fixes: a0df2cc858c3 ("drm/xe/xe_bo_move: Enhance xe_bo_move trace")
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> Cc: Oak Zeng <oak.zeng@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_trace.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_trace.h b/drivers/gpu/drm/xe/xe_trace.h
> index 0cce98a6b14b..e43c3bde3202 100644
> --- a/drivers/gpu/drm/xe/xe_trace.h
> +++ b/drivers/gpu/drm/xe/xe_trace.h
> @@ -32,7 +32,7 @@ DECLARE_EVENT_CLASS(xe_gt_tlb_invalidation_fence,
>  			     ),
>  
>  		    TP_fast_assign(
> -			   __entry->fence = (u64)fence;
> +			   __entry->fence = (unsigned long)fence;

What's the point of these weird gymnastics?
Ie. why isn't __entry->fence just a pointer?

>  			   __entry->seqno = fence->seqno;
>  			   ),
>  
> -- 
> 2.43.0

-- 
Ville Syrjälä
Intel