intel-xe.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Return immediately on tile_init failure
@ 2024-03-06 20:31 Rodrigo Vivi
  2024-03-06 20:36 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 10+ messages in thread
From: Rodrigo Vivi @ 2024-03-06 20:31 UTC (permalink / raw)
  To: intel-xe; +Cc: Rodrigo Vivi, Lucas De Marchi, Matt Roper, Matthew Auld

There's no reason to proceed with applying workaround and initing
sysfs if we are going to abort the probe upon failure.

Fixes: 876611c2b756 ("drm/xe: Memory allocations are tile-based, not GT-based")
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_tile.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_tile.c b/drivers/gpu/drm/xe/xe_tile.c
index 044c20881de7..0650b2fa75ef 100644
--- a/drivers/gpu/drm/xe/xe_tile.c
+++ b/drivers/gpu/drm/xe/xe_tile.c
@@ -167,9 +167,10 @@ int xe_tile_init_noalloc(struct xe_tile *tile)
 		goto err_mem_access;
 
 	tile->mem.kernel_bb_pool = xe_sa_bo_manager_init(tile, SZ_1M, 16);
-	if (IS_ERR(tile->mem.kernel_bb_pool))
+	if (IS_ERR(tile->mem.kernel_bb_pool)) {
 		err = PTR_ERR(tile->mem.kernel_bb_pool);
-
+		goto err_mem_access;
+	}
 	xe_wa_apply_tile_workarounds(tile);
 
 	xe_tile_sysfs_init(tile);
-- 
2.43.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-03-06 21:37 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-06 20:31 [PATCH] drm/xe: Return immediately on tile_init failure Rodrigo Vivi
2024-03-06 20:36 ` ✓ CI.Patch_applied: success for " Patchwork
2024-03-06 20:36 ` ✓ CI.checkpatch: " Patchwork
2024-03-06 20:37 ` ✓ CI.KUnit: " Patchwork
2024-03-06 20:48 ` ✓ CI.Build: " Patchwork
2024-03-06 20:48 ` ✗ CI.Hooks: failure " Patchwork
2024-03-06 20:49 ` ✓ CI.checksparse: success " Patchwork
2024-03-06 20:53 ` [PATCH] " Matt Roper
2024-03-06 21:37   ` Rodrigo Vivi
2024-03-06 21:23 ` ✓ CI.BAT: success for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).