Re: [PATCH] drm/xe/vm : Remove duplicate assignment of XE_VM_FLAG_LR_MODE flag.

[Matthew Brost <matthew.brost@intel.com>]

On Thu, Mar 07, 2024 at 12:22:13PM +0530, Himal Prasad Ghimiray wrote:
> vm->flags are already assigned with passed flags. Remove the redundant
> assignment.
> 
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_vm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 643b3701a738..b2d2852341c0 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -1369,9 +1369,8 @@ struct xe_vm *xe_vm_create(struct xe_device *xe, u32 flags)
>  		vm->batch_invalidate_tlb = true;
>  	}
>  
> -	if (flags & XE_VM_FLAG_LR_MODE) {
> +	if (vm->flags & XE_VM_FLAG_LR_MODE) {

I'd probably drop this change but it doesn't really matter.

With that:
Reviewed: Matthew Brost <matthew.brost@intel.com>

>  		INIT_WORK(&vm->preempt.rebind_work, preempt_rebind_work_func);
> -		vm->flags |= XE_VM_FLAG_LR_MODE;
>  		vm->batch_invalidate_tlb = false;
>  	}
>  
> -- 
> 2.25.1
>