Re: [PATCH] drm/xe/gt: Remove redundant num_engine check

[Andi Shyti <andi.shyti@linux.intel.com>]

Hi Tejas,

On Fri, Mar 08, 2024 at 12:33:08PM +0530, Tejas Upadhyay wrote:
> In __xe_gt_apply_ccs_mode num_engines will never be 0
> as it is already checked by parent function.
> 
> Fixes: 0d97ecce16bd ("drm/xe: Enable Fixed CCS mode setting")

I don't think you need the Fixes tag here.

With that removed:

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thanks,
Andi

> Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_gt_ccs_mode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_ccs_mode.c b/drivers/gpu/drm/xe/xe_gt_ccs_mode.c
> index 529fc286cd06..2bbd7b203cc2 100644
> --- a/drivers/gpu/drm/xe/xe_gt_ccs_mode.c
> +++ b/drivers/gpu/drm/xe/xe_gt_ccs_mode.c
> @@ -22,7 +22,7 @@ static void __xe_gt_apply_ccs_mode(struct xe_gt *gt, u32 num_engines)
>  
>  	xe_assert(xe, xe_gt_ccs_mode_enabled(gt));
>  
> -	xe_assert(xe, num_engines && num_engines <= num_slices);
> +	xe_assert(xe, num_engines <= num_slices);
>  	xe_assert(xe, !(num_slices % num_engines));
>  
>  	/*
> -- 
> 2.25.1