Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH] drm/xe: Remove debug message from migrate_clear()
Date: Sat, 6 Apr 2024 04:03:17 +0000	[thread overview]
Message-ID: <ZhDJheeNa/URlMbW@DUT025-TGLU.fm.intel.com> (raw)
In-Reply-To: <20240405153849.44906-1-jose.souza@intel.com>

On Fri, Apr 05, 2024 at 08:38:49AM -0700, José Roberto de Souza wrote:
> This messages is printed a lot and from my understanding it do not
> bring any value, so here dropping it.
> 
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>

We want to drop the similar messages in xe_migrate_copy too but this LGTM.

With that:
Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_migrate.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_migrate.c b/drivers/gpu/drm/xe/xe_migrate.c
> index 524b0198fcae3..2e37cbe35d16e 100644
> --- a/drivers/gpu/drm/xe/xe_migrate.c
> +++ b/drivers/gpu/drm/xe/xe_migrate.c
> @@ -984,7 +984,6 @@ struct dma_fence *xe_migrate_clear(struct xe_migrate *m,
>  	struct xe_res_cursor src_it;
>  	struct ttm_resource *src = dst;
>  	int err;
> -	int pass = 0;
>  
>  	if (!clear_vram)
>  		xe_res_first_sg(xe_bo_sg(bo), 0, bo->size, &src_it);
> @@ -1005,8 +1004,6 @@ struct dma_fence *xe_migrate_clear(struct xe_migrate *m,
>  
>  		clear_L0 = xe_migrate_res_sizes(m, &src_it);
>  
> -		drm_dbg(&xe->drm, "Pass %u, size: %llu\n", pass++, clear_L0);
> -
>  		/* Calculate final sizes and batch size.. */
>  		batch_size = 2 +
>  			pte_update_size(m, clear_vram, src, &src_it,
> -- 
> 2.44.0
> 

      parent reply	other threads:[~2024-04-06  4:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 15:38 [PATCH] drm/xe: Remove debug message from migrate_clear() José Roberto de Souza
2024-04-05 18:10 ` ✓ CI.Patch_applied: success for " Patchwork
2024-04-05 18:10 ` ✓ CI.checkpatch: " Patchwork
2024-04-05 18:11 ` ✓ CI.KUnit: " Patchwork
2024-04-05 18:23 ` ✓ CI.Build: " Patchwork
2024-04-05 18:25 ` ✓ CI.Hooks: " Patchwork
2024-04-05 18:27 ` ✓ CI.checksparse: " Patchwork
2024-04-05 18:51 ` ✓ CI.BAT: " Patchwork
2024-04-06  4:03 ` Matthew Brost [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZhDJheeNa/URlMbW@DUT025-TGLU.fm.intel.com \
    --to=matthew.brost@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jose.souza@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox