Re: [PATCH 1/3] drm/xe: Add max_vfs module parameter

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Apr 04, 2024 at 05:44:29PM +0200, Michal Wajdeczko wrote:
> We want to have an option to limit the number of the VFs that the
> PF driver will be able to manage.  With this limit set to zero we
> will also have a way to completely disable the PF functionality.
> 
> Since we currently don't support SR-IOV on any platform, we start
> with this limit set to zero by default.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_module.c | 7 +++++++
>  drivers/gpu/drm/xe/xe_module.h | 3 +++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_module.c b/drivers/gpu/drm/xe/xe_module.c
> index 110b69864656..ceb8345cbca6 100644
> --- a/drivers/gpu/drm/xe/xe_module.c
> +++ b/drivers/gpu/drm/xe/xe_module.c
> @@ -48,6 +48,13 @@ module_param_named_unsafe(force_probe, xe_modparam.force_probe, charp, 0400);
>  MODULE_PARM_DESC(force_probe,
>  		 "Force probe options for specified devices. See CONFIG_DRM_XE_FORCE_PROBE for details.");
>  
> +#ifdef CONFIG_PCI_IOV
> +module_param_named(max_vfs, xe_modparam.max_vfs, uint, 0400);
> +MODULE_PARM_DESC(max_vfs,
> +		 "Limit number of Virtual Functions (VFs) that could be managed. "
> +		 "(0 = no VFs [default]; N = allow up to N VFs)");
> +#endif
> +
>  struct init_funcs {
>  	int (*init)(void);
>  	void (*exit)(void);
> diff --git a/drivers/gpu/drm/xe/xe_module.h b/drivers/gpu/drm/xe/xe_module.h
> index 88ef0e8b2bfd..b369984f08ec 100644
> --- a/drivers/gpu/drm/xe/xe_module.h
> +++ b/drivers/gpu/drm/xe/xe_module.h
> @@ -18,6 +18,9 @@ struct xe_modparam {
>  	char *huc_firmware_path;
>  	char *gsc_firmware_path;
>  	char *force_probe;
> +#ifdef CONFIG_PCI_IOV
> +	unsigned int max_vfs;
> +#endif
>  };
>  
>  extern struct xe_modparam xe_modparam;
> -- 
> 2.43.0
>