Re: [PATCH] drm/xe: Remove uninitialized end var from xe_gt_tlb_invalidation_range()

[Matthew Brost <matthew.brost@intel.com>]

On Mon, Apr 29, 2024 at 05:28:21PM +0200, Nirmoy Das wrote:
> This fixes commit c4f18703629d ("drm/xe: Add
> xe_gt_tlb_invalidation_range and convert PT layer to use this")
> which added the end variable as part of the function param.
> 

Good catch, thanks. I think this needs a proper fixes tag:

Fixes: c4f18703629d ("drm/xe: Add xe_gt_tlb_invalidation_range and convert PT layer to use this")

With the new tag:
Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> Cc: Matthew Brost <matthew.brost@intel.com>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> index d0ee1e0df0bd..c3d015a7ac33 100644
> --- a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> +++ b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> @@ -305,7 +305,7 @@ int xe_gt_tlb_invalidation_range(struct xe_gt *gt,
>  	} else {
>  		u64 orig_start = start;
>  		u64 length = end - start;
> -		u64 align, end;
> +		u64 align;
>  
>  		if (length < SZ_4K)
>  			length = SZ_4K;
> -- 
> 2.42.0
>