Re: [PATCH 000/123] drm/i915: remove implicit dev_priv local variable use

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Apr 26, 2024 at 04:09:45PM +0300, Jani Nikula wrote:
> On Fri, 26 Apr 2024, Jani Nikula <jani.nikula@intel.com> wrote:
> > Hey all, it's time to stop using the implicit dev_priv local variable in
> > register macros. Yes, this is huge. It's also (almost) completely
> > scripted.
> 
> Okay, I was first going to send the entire series, but chickened out and
> hit ^C when git send-email was going though the patches. You get the
> idea with what's here. It's just more of the same. Plus I pushed the lot
> to [1].

now it makes sense. I was wondering why I was only seeing a few patches
when the series was telling over a hundred.

> 
> I think we'll need to do this. 

Agreed. Let's do this.

> The question is how to handle this
> churn. Do we want this many patches? If not, how much to squash?

From a glance on these initial patches, it sounds really organized in
individual patches and easy to review.
Perhaps if we take this path we might just split the series in blocks
and merge these initial 17, and we continue over the next weeks.

However, if this is automated like you mentioned in the cover letter,
perhaps we can do one patch per directory? (display vs gvt vs gem? vs drm/i915/{.c,.h})

> 
> 
> BR,
> Jani.
> 
> 
> [1] https://gitlab.freedesktop.org/jani/linux/-/commits/regs-mass-dev-priv-removal/?ref_type=heads
> 
> 
> -- 
> Jani Nikula, Intel