Re: [PATCH v6 2/3] drm/xe: Add helpers to loop over geometry and compute DSS

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Apr 05, 2024 at 11:23:25AM -0700, José Roberto de Souza wrote:
> Some DSS can only be available for geometry while others can only be
> available for compute.
> So here adding helpers to loop only available DSS for given usage.
> 
> User of this helper will come in the next patch.
> 
> v2:
> - drop has_dss()
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Zhanjun Dong <zhanjun.dong@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_gt_mcr.h      | 24 ++++++++++++++++++++++++
>  drivers/gpu/drm/xe/xe_gt_topology.c | 10 ++++++++++
>  drivers/gpu/drm/xe/xe_gt_topology.h |  3 +++
>  3 files changed, 37 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_mcr.h b/drivers/gpu/drm/xe/xe_gt_mcr.h
> index a7f4ab1aa584b..e7d03e001a49f 100644
> --- a/drivers/gpu/drm/xe/xe_gt_mcr.h
> +++ b/drivers/gpu/drm/xe/xe_gt_mcr.h
> @@ -40,4 +40,28 @@ void xe_gt_mcr_get_dss_steering(struct xe_gt *gt, unsigned int dss, u16 *group,
>  	for_each_dss((dss), (gt)) \
>  		for_each_if((xe_gt_mcr_get_dss_steering((gt), (dss), &(group), &(instance)), true))
>  
> +/*
> + * Loop over each DSS available for geometry and determine the group and
> + * instance IDs that should be used to steer MCR accesses toward this DSS.
> + * @dss: DSS ID to obtain steering for
> + * @gt: GT structure
> + * @group: steering group ID, data type: u16
> + * @instance: steering instance ID, data type: u16
> + */
> +#define for_each_geometry_dss(dss, gt, group, instance) \
> +		for_each_dss_steering(dss, gt, group, instance) \
> +			if (xe_gt_has_geometry_dss(gt, dss))
> +
> +/*
> + * Loop over each DSS available for compute and determine the group and
> + * instance IDs that should be used to steer MCR accesses toward this DSS.
> + * @dss: DSS ID to obtain steering for
> + * @gt: GT structure
> + * @group: steering group ID, data type: u16
> + * @instance: steering instance ID, data type: u16
> + */
> +#define for_each_compute_dss(dss, gt, group, instance) \
> +		for_each_dss_steering(dss, gt, group, instance) \
> +			if (xe_gt_has_compute_dss(gt, dss))
> +
>  #endif /* _XE_GT_MCR_H_ */
> diff --git a/drivers/gpu/drm/xe/xe_gt_topology.c b/drivers/gpu/drm/xe/xe_gt_topology.c
> index f5773a14f3c8e..e2eff4f10ad9b 100644
> --- a/drivers/gpu/drm/xe/xe_gt_topology.c
> +++ b/drivers/gpu/drm/xe/xe_gt_topology.c
> @@ -166,3 +166,13 @@ bool xe_gt_topology_has_dss_in_quadrant(struct xe_gt *gt, int quad)
>  
>  	return quad_first < (quad + 1) * dss_per_quad;
>  }
> +
> +bool xe_gt_has_geometry_dss(struct xe_gt *gt, unsigned int dss)
> +{
> +	return test_bit(dss, gt->fuse_topo.g_dss_mask);
> +}
> +
> +bool xe_gt_has_compute_dss(struct xe_gt *gt, unsigned int dss)
> +{
> +	return test_bit(dss, gt->fuse_topo.c_dss_mask);
> +}
> diff --git a/drivers/gpu/drm/xe/xe_gt_topology.h b/drivers/gpu/drm/xe/xe_gt_topology.h
> index b3e357777a6e7..746b325bbf6e4 100644
> --- a/drivers/gpu/drm/xe/xe_gt_topology.h
> +++ b/drivers/gpu/drm/xe/xe_gt_topology.h
> @@ -33,4 +33,7 @@ bool xe_dss_mask_empty(const xe_dss_mask_t mask);
>  bool
>  xe_gt_topology_has_dss_in_quadrant(struct xe_gt *gt, int quad);
>  
> +bool xe_gt_has_geometry_dss(struct xe_gt *gt, unsigned int dss);
> +bool xe_gt_has_compute_dss(struct xe_gt *gt, unsigned int dss);
> +
>  #endif /* _XE_GT_TOPOLOGY_H_ */
> -- 
> 2.44.0
>