From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: intel-xe@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH] drm/xe: Rename few xe_args.h macros
Date: Tue, 7 May 2024 16:08:23 +0300 [thread overview]
Message-ID: <ZjonxyRr6K91Rytg@smile.fi.intel.com> (raw)
In-Reply-To: <20240506215618.2703-1-michal.wajdeczko@intel.com>
On Mon, May 06, 2024 at 11:56:18PM +0200, Michal Wajdeczko wrote:
> To minimize the risk of future name collisions, rename macros to
> always include the ARG or ARGS tag:
>
> DROP_FIRST to ARGS_TAIL
> PICK_FIRST to FIRST_ARG
> PICK_LAST to LAST_ARG
>
> Suggested-by:: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
One colon is enough :-)
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
No need to have a Cc for the person who has already mentioned in another tag.
With above being addressed,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-07 13:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 21:56 [PATCH] drm/xe: Rename few xe_args.h macros Michal Wajdeczko
2024-05-07 3:29 ` ✓ CI.Patch_applied: success for " Patchwork
2024-05-07 3:29 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-07 3:30 ` ✓ CI.KUnit: success " Patchwork
2024-05-07 3:44 ` ✓ CI.Build: " Patchwork
2024-05-07 3:54 ` ✓ CI.Hooks: " Patchwork
2024-05-07 3:55 ` ✓ CI.checksparse: " Patchwork
2024-05-07 4:13 ` ✓ CI.BAT: " Patchwork
2024-05-07 8:28 ` ✗ CI.FULL: failure " Patchwork
2024-05-07 13:08 ` Andy Shevchenko [this message]
2024-05-07 13:24 ` [PATCH] " Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjonxyRr6K91Rytg@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox