From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: intel-xe@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH v2] drm/xe: Rename few xe_args.h macros
Date: Tue, 7 May 2024 19:28:43 +0300 [thread overview]
Message-ID: <ZjpWuy5inznQdNWl@smile.fi.intel.com> (raw)
In-Reply-To: <20240507152246.2791-1-michal.wajdeczko@intel.com>
On Tue, May 07, 2024 at 05:22:46PM +0200, Michal Wajdeczko wrote:
> To minimize the risk of future name collisions, rename macros to
> always include the ARG or ARGS tag:
>
> DROP_FIRST to DROP_FIRST_ARG
> PICK_FIRST to FIRST_ARG
> PICK_LAST to LAST_ARG
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Seems I already gave a tag...
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-07 16:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 15:22 [PATCH v2] drm/xe: Rename few xe_args.h macros Michal Wajdeczko
2024-05-07 16:28 ` Andy Shevchenko [this message]
2024-05-07 16:34 ` ✓ CI.Patch_applied: success for drm/xe: Rename few xe_args.h macros (rev2) Patchwork
2024-05-07 16:35 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-07 16:36 ` ✓ CI.KUnit: success " Patchwork
2024-05-07 16:48 ` ✓ CI.Build: " Patchwork
2024-05-07 16:54 ` ✓ CI.Hooks: " Patchwork
2024-05-07 17:02 ` ✓ CI.checksparse: " Patchwork
2024-05-07 17:44 ` ✓ CI.BAT: " Patchwork
2024-05-08 0:06 ` ✗ CI.FULL: failure " Patchwork
2024-05-08 3:33 ` [PATCH v2] drm/xe: Rename few xe_args.h macros Lucas De Marchi
2024-05-08 16:33 ` Michal Wajdeczko
2024-05-08 16:59 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjpWuy5inznQdNWl@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox