Re: [PATCH 0/7] Unlock deeper package-C states (PC-10) and D3Cold

[Francois Dugast <francois.dugast@intel.com>]

Hi Rodrigo,

On Fri, May 03, 2024 at 03:13:02PM -0400, Rodrigo Vivi wrote:
> For integrated graphics, this series mean the unlock of
> deeper package-C states. With this, on MTL I'm glad to
> see PC-10 even with display enabled (with eDP PSR).
> 
> On my DG2 I'm gladly getting the big saves of D3Cold when
> display is off/idle. And everything working niftly on
> the desktop environment.

This is really great. I just tested the latest version of
this series on ADL-P and confirm the device now suspends
in an idle desktop session, whereas previously this was
prevented by held references (power/runtime_usage > 0).
Besides, no other issue so far so feel free to add to
the whole series:

Tested-by: Francois Dugast <francois.dugast@intel.com>

Thanks,
Francois

> 
> But in order to achieve that, we need to relax the runtime
> PM protection around VMs and exec_queue, as explained on
> each individual patch touching them.
> 
> Please let me know your thoughts, specially around those
> relaxation cases.
> 
> Thanks,
> Rodrigo.
> 
> Rodrigo Vivi (7):
>   drm/xe: Fix xe_pm_runtime_get_if_active return
>   drm/xe: Fix xe_pm_runtime_get_if_in_use documentation
>   drm/xe: Relax runtime pm protection during execution
>   drm/xe: Relax runtime pm protection around VM
>   drm/xe: Prepare display for D3Cold
>   drm/xe: Stop checking for power_lost on D3Cold
>   drm/xe: Enable D3Cold on 'low' VRAM utilization
> 
>  drivers/gpu/drm/xe/display/xe_display.c | 10 ++++---
>  drivers/gpu/drm/xe/display/xe_display.h |  8 ++---
>  drivers/gpu/drm/xe/xe_bo.c              | 17 ++++++++++-
>  drivers/gpu/drm/xe/xe_device_types.h    |  3 --
>  drivers/gpu/drm/xe/xe_exec_queue.c      | 14 ---------
>  drivers/gpu/drm/xe/xe_guc.c             | 27 -----------------
>  drivers/gpu/drm/xe/xe_guc.h             |  1 -
>  drivers/gpu/drm/xe/xe_guc_submit.c      |  3 ++
>  drivers/gpu/drm/xe/xe_pm.c              | 40 +++++++++++++------------
>  drivers/gpu/drm/xe/xe_pm.h              |  9 ++----
>  drivers/gpu/drm/xe/xe_sched_job.c       | 10 ++-----
>  drivers/gpu/drm/xe/xe_vm.c              |  6 ++--
>  12 files changed, 58 insertions(+), 90 deletions(-)
> 
> -- 
> 2.44.0
>