Re: [PATCH 4/4] drm/xe: Fix xe_reg_sr.h

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, May 13, 2024 at 10:42:18AM +0200, Michal Wajdeczko wrote:
> Prefer forward declarations over #include xe_reg_sr_types.h

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_reg_sr.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_reg_sr.h b/drivers/gpu/drm/xe/xe_reg_sr.h
> index e3197c33afe2..51fbba423e27 100644
> --- a/drivers/gpu/drm/xe/xe_reg_sr.h
> +++ b/drivers/gpu/drm/xe/xe_reg_sr.h
> @@ -6,8 +6,6 @@
>  #ifndef _XE_REG_SR_
>  #define _XE_REG_SR_
>  
> -#include "xe_reg_sr_types.h"
> -
>  /*
>   * Reg save/restore bookkeeping
>   */
> @@ -15,6 +13,8 @@
>  struct xe_device;
>  struct xe_gt;
>  struct xe_hw_engine;
> +struct xe_reg_sr;
> +struct xe_reg_sr_entry;
>  struct drm_printer;
>  
>  int xe_reg_sr_init(struct xe_reg_sr *sr, const char *name, struct xe_device *xe);
> -- 
> 2.43.0
>