From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Riana Tauro <riana.tauro@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <anshuman.gupta@intel.com>,
<vinay.belgaumkar@intel.com>
Subject: Re: [PATCH 1/2] drm/xe/xe_gt_idle: use GT forcewake domain assertion
Date: Mon, 13 May 2024 11:45:39 -0400 [thread overview]
Message-ID: <ZkI1o3TuEaRDRfsm@intel.com> (raw)
In-Reply-To: <20240513070546.3754640-2-riana.tauro@intel.com>
On Mon, May 13, 2024 at 12:35:45PM +0530, Riana Tauro wrote:
> The rc6 registers used in disable_c6 function belong
> to the GT forcewake domain. Hence change the forcewake
> assertion to check GT forcewake domain.
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Signed-off-by: Riana Tauro <riana.tauro@intel.com>
> ---
> drivers/gpu/drm/xe/xe_gt_idle.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_idle.c b/drivers/gpu/drm/xe/xe_gt_idle.c
> index a4f6f0a96d05..2f247cb910d1 100644
> --- a/drivers/gpu/drm/xe/xe_gt_idle.c
> +++ b/drivers/gpu/drm/xe/xe_gt_idle.c
> @@ -200,7 +200,7 @@ void xe_gt_idle_enable_c6(struct xe_gt *gt)
> void xe_gt_idle_disable_c6(struct xe_gt *gt)
> {
> xe_device_assert_mem_access(gt_to_xe(gt));
> - xe_force_wake_assert_held(gt_to_fw(gt), XE_FORCEWAKE_ALL);
> + xe_force_wake_assert_held(gt_to_fw(gt), XE_FW_GT);
>
> xe_mmio_write32(gt, PG_ENABLE, 0);
> xe_mmio_write32(gt, RC_CONTROL, 0);
> --
> 2.40.0
>
next prev parent reply other threads:[~2024-05-13 15:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 7:05 [PATCH 0/2] xe_gt_idle fixes Riana Tauro
2024-05-13 7:05 ` [PATCH 1/2] drm/xe/xe_gt_idle: use GT forcewake domain assertion Riana Tauro
2024-05-13 15:45 ` Rodrigo Vivi [this message]
2024-05-13 7:05 ` [PATCH 2/2] drm/xe: move disable_c6 call Riana Tauro
2024-05-13 15:51 ` Rodrigo Vivi
2024-05-14 5:05 ` Riana Tauro
2024-05-13 8:51 ` ✓ CI.Patch_applied: success for xe_gt_idle fixes Patchwork
2024-05-13 8:51 ` ✓ CI.checkpatch: " Patchwork
2024-05-13 8:52 ` ✓ CI.KUnit: " Patchwork
2024-05-13 9:04 ` ✓ CI.Build: " Patchwork
2024-05-13 9:07 ` ✓ CI.Hooks: " Patchwork
2024-05-13 9:08 ` ✓ CI.checksparse: " Patchwork
2024-05-13 9:30 ` ✓ CI.BAT: " Patchwork
2024-05-13 10:40 ` ✓ CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkI1o3TuEaRDRfsm@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=riana.tauro@intel.com \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox