From: Matthew Brost <matthew.brost@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [RFC PATCH 1/5] drm/xe: Add LRC ctx timestamp support functions
Date: Fri, 7 Jun 2024 15:16:10 +0000 [thread overview]
Message-ID: <ZmMkOmu0nfwBMrEY@DUT025-TGLU.fm.intel.com> (raw)
In-Reply-To: <87bk4dmdmp.fsf@intel.com>
On Fri, Jun 07, 2024 at 10:10:54AM +0300, Jani Nikula wrote:
> On Thu, 06 Jun 2024, Matthew Brost <matthew.brost@intel.com> wrote:
> > +static inline u32 __xe_lrc_ctx_timestamp_job_offset(struct xe_lrc *lrc)
>
> Please don't use the inline keyword in .c files, no matter how simple
> the function. Just let the compiler do its job of inlining as
> needed. Using inline also silences warnings about unused static
> functions.
>
I'm aware of not using static inline in *.c file agree. This file has
thia design patch and actually doing this intentionally in a few spots,
so followew that design pattern. It use static inlines as some functions
spit out via magic macros are unused. Let me just clean this up so some
the functions spit out are annotated correctly...
Matt
> BR,
> Jani.
>
>
> --
> Jani Nikula, Intel
next prev parent reply other threads:[~2024-06-07 15:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 6:52 [RFC PATCH 0/5] Only timeout jobs if they run longer than timeout period Matthew Brost
2024-06-07 6:52 ` [RFC PATCH 1/5] drm/xe: Add LRC ctx timestamp support functions Matthew Brost
2024-06-07 7:10 ` Jani Nikula
2024-06-07 15:16 ` Matthew Brost [this message]
2024-06-07 6:52 ` [RFC PATCH 2/5] drm/xe: Add MI_COPY_MEM_MEM GPU instruction definitions Matthew Brost
2024-06-07 11:04 ` Michal Wajdeczko
2024-06-07 15:22 ` Matthew Brost
2024-06-07 6:52 ` [RFC PATCH 3/5] drm/xe: Emit ctx timestamp copy in ring ops Matthew Brost
2024-06-07 6:52 ` [RFC PATCH 4/5] drm/xe: Add ctx timestamp to LRC snapshot Matthew Brost
2024-06-07 6:52 ` [RFC PATCH 5/5] drm/xe: Sample ctx timestamp to determine if jobs have timed out Matthew Brost
2024-06-07 6:56 ` ✓ CI.Patch_applied: success for Only timeout jobs if they run longer than timeout period Patchwork
2024-06-07 6:56 ` ✗ CI.checkpatch: warning " Patchwork
2024-06-07 6:57 ` ✓ CI.KUnit: success " Patchwork
2024-06-07 7:09 ` ✓ CI.Build: " Patchwork
2024-06-07 7:11 ` ✓ CI.Hooks: " Patchwork
2024-06-07 7:13 ` ✓ CI.checksparse: " Patchwork
2024-06-07 15:27 ` ✗ CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmMkOmu0nfwBMrEY@DUT025-TGLU.fm.intel.com \
--to=matthew.brost@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox