Re: [PATCH v2 1/2] drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Jun 14, 2024 at 03:53:04PM -0400, Rodrigo Vivi wrote:
> On Fri, Jun 14, 2024 at 09:55:57AM +0530, Mitul Golani wrote:
> > Describe newly added parameter target_rr_divider in struct
> > drm_dp_as_sdp.
> > 
> > -v2:
> > Remove extra line from commit message.(Lucas)
> > 
> > Fixes: a20c6d954d75 ("drm/dp: Add refresh rate divider to struct representing AS SDP")
> > Cc: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
> > Cc: Arun R Murthy <arun.r.murthy@intel.com>
> > Cc: Suraj Kandpal <suraj.kandpal@intel.com>
> > Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> > Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
> > Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> > ---
> >  include/drm/display/drm_dp_helper.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h
> > index ea03e1dd26ba..7f2567fa230d 100644
> > --- a/include/drm/display/drm_dp_helper.h
> > +++ b/include/drm/display/drm_dp_helper.h
> > @@ -112,6 +112,7 @@ struct drm_dp_vsc_sdp {
> >   * @target_rr: Target Refresh
> >   * @duration_incr_ms: Successive frame duration increase
> >   * @duration_decr_ms: Successive frame duration decrease
> > + * @target_rr_divider: Target refresh rate divider
> 
> Maarten, Maxime, or Thomas,
> the patch introducing this target_rr_divider is in drm-intel-next.
> Ack on adding this through drm-intel-next as well?

I got Maxime's ack on irc to go ahead here. But I just noticed
that this actually conflicts with commit c7ce956bb6d0 ("drm/dp: Fix
documentation warning") which is only applied on drm-misc-next.

With that, I prefer to hold so the branches are in sync again
so we send a patch that applies cleanly.

> 
> >   * @mode: Adaptive Sync Operation Mode
> >   */
> >  struct drm_dp_as_sdp {
> > -- 
> > 2.45.2
> >