Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Karthik Poosa <karthik.poosa@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <anshuman.gupta@intel.com>,
	<badal.nilawar@intel.com>, <lucas.demarchi@intel.com>
Subject: Re: [PATCH v3 0/1] drm/xe/hwmon: Remove xe_hwmon_process_reg
Date: Wed, 26 Jun 2024 13:30:18 -0400	[thread overview]
Message-ID: <ZnxPyXN-RWy9pSwr@intel.com> (raw)
In-Reply-To: <20240626170746.2926011-1-karthik.poosa@intel.com>

On Wed, Jun 26, 2024 at 10:37:45PM +0530, Karthik Poosa wrote:
>  Removing xe_hwmon_process_reg as per review comments from Lucas in
> https://patchwork.freedesktop.org/patch/587830/?series=131765&rev=7.
> 
> It was reviewed as an umbrella function which can be avoided.
> 
> v2:
>  - Rebase.
>  - Improve commit message of patch and cover letter. (Badal)
> 
> v3:
>  - Rebase.
>  - Add couple of comments. (Lucas)

please avoid the cover-letter for standalone patches. specially with
cover letter that brings no new information.
But anyway, if information is needed in a standallone patch, it is
better to add in the patch file below the '--' mark under the sign-off block,
so that is included in the email, but not part of the commit message itself.


> 
> Karthik Poosa (1):
>   drm/xe/hwmon: Remove xe_hwmon_process_reg
> 
>  drivers/gpu/drm/xe/xe_hwmon.c | 89 ++++++++++++++++-------------------
>  1 file changed, 40 insertions(+), 49 deletions(-)
> 
> -- 
> 2.25.1
> 

  parent reply	other threads:[~2024-06-26 17:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-26 17:07 [PATCH v3 0/1] drm/xe/hwmon: Remove xe_hwmon_process_reg Karthik Poosa
2024-06-26 17:00 ` ✓ CI.Patch_applied: success for " Patchwork
2024-06-26 17:00 ` ✓ CI.checkpatch: " Patchwork
2024-06-26 17:01 ` ✓ CI.KUnit: " Patchwork
2024-06-26 17:07 ` [PATCH v3 1/1] " Karthik Poosa
2024-06-26 17:13 ` ✓ CI.Build: success for " Patchwork
2024-06-26 17:15 ` ✓ CI.Hooks: " Patchwork
2024-06-26 17:17 ` ✓ CI.checksparse: " Patchwork
2024-06-26 17:30 ` Rodrigo Vivi [this message]
2024-06-26 17:39 ` ✓ CI.BAT: " Patchwork
2024-06-27  0:30 ` ✓ CI.FULL: " Patchwork
2024-06-27 18:52 ` [PATCH v3 0/1] " Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZnxPyXN-RWy9pSwr@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=karthik.poosa@intel.com \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox