From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06448C531DF for ; Fri, 16 Aug 2024 14:16:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C91B610E7BA; Fri, 16 Aug 2024 14:16:08 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id B26DD10E7B9 for ; Fri, 16 Aug 2024 14:16:06 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6BD311474 for ; Fri, 16 Aug 2024 07:16:32 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 38E373F73B for ; Fri, 16 Aug 2024 07:16:06 -0700 (PDT) Date: Fri, 16 Aug 2024 15:15:56 +0100 From: Liviu Dudau To: Thomas Zimmermann Cc: daniel@ffwll.ch, airlied@gmail.com, jfalempe@redhat.com, javierm@redhat.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org Subject: Re: [PATCH 08/86] drm/arm/hdlcd: Run DRM default client setup Message-ID: References: <20240816125408.310253-1-tzimmermann@suse.de> <20240816125408.310253-9-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240816125408.310253-9-tzimmermann@suse.de> X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, Aug 16, 2024 at 02:22:34PM +0200, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The hdlcd driver specifies a preferred color mode of 32. As this > is the default if no format has been given, leave it out entirely. > > Signed-off-by: Thomas Zimmermann > Cc: Liviu Dudau Acked-by: Liviu Dudau > --- > drivers/gpu/drm/arm/hdlcd_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c > index 32be9e370049..f5d358f3893b 100644 > --- a/drivers/gpu/drm/arm/hdlcd_drv.c > +++ b/drivers/gpu/drm/arm/hdlcd_drv.c > @@ -23,6 +23,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -228,6 +229,7 @@ DEFINE_DRM_GEM_DMA_FOPS(fops); > static const struct drm_driver hdlcd_driver = { > .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, > DRM_GEM_DMA_DRIVER_OPS, > + DRM_FBDEV_DMA_DRIVER_OPS, > .fops = &fops, > .name = "hdlcd", > .desc = "ARM HDLCD Controller DRM", > @@ -299,7 +301,7 @@ static int hdlcd_drm_bind(struct device *dev) > if (ret) > goto err_register; > > - drm_fbdev_dma_setup(drm, 32); > + drm_client_setup(drm, NULL); > > return 0; > > -- > 2.46.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯