Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: intel-xe@lists.freedesktop.org,
	"Dominik Grzegorzek" <dominik.grzegorzek@intel.com>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Subject: Re: [PATCH 2/2] drm/xe: Add kernel doc for xe_hw_engine_lookup
Date: Tue, 6 Aug 2024 20:41:39 +0000	[thread overview]
Message-ID: <ZrKKg2YgOWqDbcmn@DUT025-TGLU.fm.intel.com> (raw)
In-Reply-To: <20240806153009.1081382-2-mika.kuoppala@linux.intel.com>

On Tue, Aug 06, 2024 at 06:30:09PM +0300, Mika Kuoppala wrote:
> kerneldoc was missing from earlier commit where
> we exported xe_hw_engine_lookup. Add it.
> 
> Fixes: 6f20fc09936e ("drm/xe: Move and export xe_hw_engine lookup.")

You don't need the fixes tag, will remove upon merging this.

Matt

> Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
> Cc: intel-xe@lists.freedesktop.org
> Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
>  drivers/gpu/drm/xe/xe_hw_engine.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c b/drivers/gpu/drm/xe/xe_hw_engine.c
> index c7c44de7c30f..68180f1ff8a9 100644
> --- a/drivers/gpu/drm/xe/xe_hw_engine.c
> +++ b/drivers/gpu/drm/xe/xe_hw_engine.c
> @@ -1173,6 +1173,16 @@ static const enum xe_engine_class user_to_xe_engine_class[] = {
>  	[DRM_XE_ENGINE_CLASS_COMPUTE] = XE_ENGINE_CLASS_COMPUTE,
>  };
>  
> +/**
> + * xe_hw_engine_lookup() - Lookup hardware engine for class:instance
> + * @xe: xe device
> + * @eci: engine class and instance
> + *
> + * This function will find a hardware engine for given engine
> + * class and instance.
> + *
> + * Return: If found xe_hw_engine pointer, NULL otherwise.
> + */
>  struct xe_hw_engine *
>  xe_hw_engine_lookup(struct xe_device *xe,
>  		    struct drm_xe_engine_class_instance eci)
> -- 
> 2.34.1
> 

  parent reply	other threads:[~2024-08-06 20:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-06 15:30 [PATCH 1/2] drm/xe: Export xe_hw_engine's mmio accessors Mika Kuoppala
2024-08-06 15:30 ` [PATCH 2/2] drm/xe: Add kernel doc for xe_hw_engine_lookup Mika Kuoppala
2024-08-06 19:23   ` Cavitt, Jonathan
2024-08-06 20:41   ` Matthew Brost [this message]
2024-08-06 16:15 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe: Export xe_hw_engine's mmio accessors Patchwork
2024-08-06 16:15 ` ✗ CI.checkpatch: warning " Patchwork
2024-08-06 16:16 ` ✓ CI.KUnit: success " Patchwork
2024-08-06 16:28 ` ✓ CI.Build: " Patchwork
2024-08-06 16:30 ` ✓ CI.Hooks: " Patchwork
2024-08-06 16:32 ` ✓ CI.checksparse: " Patchwork
2024-08-06 16:52 ` ✓ CI.BAT: " Patchwork
2024-08-06 20:07 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZrKKg2YgOWqDbcmn@DUT025-TGLU.fm.intel.com \
    --to=matthew.brost@intel.com \
    --cc=dominik.grzegorzek@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=mika.kuoppala@linux.intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox