Re: [PATCH v7 12/13] drm/xe/vm: Remove restriction that all VMs must be faulting if one is

[Matthew Brost <matthew.brost@intel.com>]

On Wed, Aug 07, 2024 at 06:23:41PM +0200, Francois Dugast wrote:
> With this restriction, all VMs on the device must be faulting VMs if there
> is already one faulting VM, in which case the device is considered in
> fault mode. This prevents for example an application from running 3D jobs
> for the compositor while submitting a SVM compute job on the same device.
> 
> Now that mutual exclusion of faulting LR jobs and dma fence jobs is
> ensured on the hw engine group, remove this restriction to allow running
> faulting and non-faulting VMs on the same device.
> 
> Signed-off-by: Francois Dugast <francois.dugast@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_vm.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index b715883f40d8..7a88c65759c9 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -1769,14 +1769,6 @@ int xe_vm_create_ioctl(struct drm_device *dev, void *data,
>  			 args->flags & DRM_XE_VM_CREATE_FLAG_FAULT_MODE))
>  		return -EINVAL;
>  
> -	if (XE_IOCTL_DBG(xe, args->flags & DRM_XE_VM_CREATE_FLAG_FAULT_MODE &&
> -			 xe_device_in_non_fault_mode(xe)))
> -		return -EINVAL;
> -
> -	if (XE_IOCTL_DBG(xe, !(args->flags & DRM_XE_VM_CREATE_FLAG_FAULT_MODE) &&
> -			 xe_device_in_fault_mode(xe)))
> -		return -EINVAL;
> -
>  	if (XE_IOCTL_DBG(xe, args->extensions))
>  		return -EINVAL;
>  
> -- 
> 2.43.0
>