Re: [PATCH 0/4] drm/i915/display: add snapshot capture/print infra

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Tue, Sep 03, 2024 at 05:02:56PM +0300, Jani Nikula wrote:
> Add display capture/print infra to abstract it from i915 gpu error state
> capture, and prepare for perhaps bolting it into xe devcoredump in the
> future.

One thing that just occurred to me now is that perhaps we don't want
to add that to the xe devcoredump itself, but make display having it's
own coredump virtual device?

Do we really need to dump only when GT is hang? Or perhaps adding more
useful information on display and print on display goof-ups?

But anyway, it could be orthogonal and Xe also use these display functions
on gpu hang as well. Nice work!

> 
> BR,
> Jani.
> 
> 
> Jani Nikula (4):
>   drm/i915: dump display parameters captured in error state, not current
>   drm/i915/display: add intel_display_snapshot abstraction
>   drm/i915/display: move device info and params handling to snapshot
>   drm/i915/display: move dmc snapshotting to new display snapshot
> 
>  drivers/gpu/drm/i915/Makefile                 |  1 +
>  .../drm/i915/display/intel_display_params.c   |  8 ++-
>  .../drm/i915/display/intel_display_params.h   |  5 +-
>  .../drm/i915/display/intel_display_snapshot.c | 72 +++++++++++++++++++
>  .../drm/i915/display/intel_display_snapshot.h | 16 +++++
>  drivers/gpu/drm/i915/display/intel_dmc.c      | 39 +++++++---
>  drivers/gpu/drm/i915/display/intel_dmc.h      |  7 +-
>  drivers/gpu/drm/i915/display/intel_overlay.c  | 16 +++--
>  drivers/gpu/drm/i915/display/intel_overlay.h  | 19 ++---
>  drivers/gpu/drm/i915/i915_debugfs.c           |  2 +-
>  drivers/gpu/drm/i915/i915_gpu_error.c         | 25 ++-----
>  drivers/gpu/drm/i915/i915_gpu_error.h         | 11 +--
>  12 files changed, 162 insertions(+), 59 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/display/intel_display_snapshot.c
>  create mode 100644 drivers/gpu/drm/i915/display/intel_display_snapshot.h
> 
> -- 
> 2.39.2
>