intel-xe.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] drm: Ensure Proper Unload/Reload Order of MEI Modules for i915/Xe Driver
@ 2024-09-09  4:03 Bommu Krishnaiah
  2024-09-10  7:34 ` ✓ CI.Patch_applied: success for drm: Ensure Proper Unload/Reload Order of MEI Modules for i915/Xe Driver (rev2) Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 17+ messages in thread
From: Bommu Krishnaiah @ 2024-09-09  4:03 UTC (permalink / raw)
  To: intel-xe
  Cc: intel-gfx, Bommu Krishnaiah, Kamil Konieczny,
	Daniele Ceraolo Spurio, Lucas De Marchi, Tejas Upadhyay

This update addresses the unload/reload sequence of MEI modules in relation to
the i915/Xe graphics driver. On platforms where the MEI hardware is integrated
with the graphics device (e.g., DG2/BMG), the i915/xe driver is depend on the MEI
modules. Conversely, on newer platforms like MTL and LNL, where the MEI hardware
is separate, this dependency does not exist.

The changes introduced ensure that MEI modules are unloaded and reloaded in the
correct order based on platform-specific dependencies. This is achieved by adding
a MODULE_SOFTDEP directive to the i915 and Xe module code.

These changes enhance the robustness of MEI module handling across different hardware
platforms, ensuring that the i915/Xe driver can be cleanly unloaded and reloaded
without issues.

v2: updated commit message

Signed-off-by: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Tejas Upadhyay <tejas.upadhyay@intel.com>
---
 drivers/gpu/drm/i915/i915_module.c | 2 ++
 drivers/gpu/drm/xe/xe_module.c     | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_module.c b/drivers/gpu/drm/i915/i915_module.c
index 65acd7bf75d0..2ad079ad35db 100644
--- a/drivers/gpu/drm/i915/i915_module.c
+++ b/drivers/gpu/drm/i915/i915_module.c
@@ -75,6 +75,8 @@ static const struct {
 };
 static int init_progress;
 
+MODULE_SOFTDEP("pre: mei_gsc_proxy mei_gsc");
+
 static int __init i915_init(void)
 {
 	int err, i;
diff --git a/drivers/gpu/drm/xe/xe_module.c b/drivers/gpu/drm/xe/xe_module.c
index bfc3deebdaa2..5633ea1841b7 100644
--- a/drivers/gpu/drm/xe/xe_module.c
+++ b/drivers/gpu/drm/xe/xe_module.c
@@ -127,6 +127,8 @@ static void xe_call_exit_func(unsigned int i)
 	init_funcs[i].exit();
 }
 
+MODULE_SOFTDEP("pre: mei_gsc_proxy mei_gsc");
+
 static int __init xe_init(void)
 {
 	int err, i;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 17+ messages in thread
end of thread, other threads:[~2024-09-13 22:21 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-09  4:03 [PATCH v2] drm: Ensure Proper Unload/Reload Order of MEI Modules for i915/Xe Driver Bommu Krishnaiah
2024-09-10  7:34 ` ✓ CI.Patch_applied: success for drm: Ensure Proper Unload/Reload Order of MEI Modules for i915/Xe Driver (rev2) Patchwork
2024-09-10  7:34 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-10  7:35 ` ✓ CI.KUnit: success " Patchwork
2024-09-10  7:50 ` ✓ CI.Build: " Patchwork
2024-09-10  7:52 ` ✓ CI.Hooks: " Patchwork
2024-09-10  7:56 ` ✗ CI.checksparse: warning " Patchwork
2024-09-10  8:45 ` ✗ CI.BAT: failure " Patchwork
2024-09-10  9:55 ` ✗ CI.FULL: " Patchwork
2024-09-10 15:03 ` [PATCH v2] drm: Ensure Proper Unload/Reload Order of MEI Modules for i915/Xe Driver Rodrigo Vivi
2024-09-10 15:43   ` Lucas De Marchi
2024-09-11  6:00     ` Bommu, Krishnaiah
2024-09-11 16:18       ` Lucas De Marchi
2024-09-12 11:58         ` Bommu, Krishnaiah
2024-09-12 20:42           ` Lucas De Marchi
2024-09-13 22:21             ` Lucas De Marchi
2024-09-11 20:41       ` Rodrigo Vivi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).