From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Riana Tauro <riana.tauro@intel.com>,
Matthew Brost <matthew.brost@intel.com>,
<intel-xe@lists.freedesktop.org>, <jani.nikula@linux.intel.com>
Subject: Re: [PATCH] drm/xe/xe_gt_idle: Fix name conflict
Date: Tue, 10 Sep 2024 13:23:41 -0400 [thread overview]
Message-ID: <ZuCAnYNYC8_ICcKC@intel.com> (raw)
In-Reply-To: <yc4ftt3mt5pvah6kgr2kkq2rv3pf6s7swi3uqp77nd3tyzxloj@fpjowiwgpjxt>
On Tue, Sep 10, 2024 at 11:48:20AM -0500, Lucas De Marchi wrote:
> On Tue, Sep 10, 2024 at 09:55:23PM GMT, Riana Tauro wrote:
> > Hi Rodrigo/ Matthew
> >
> > There was an error when this change was merged to linux-next
> > https://lore.kernel.org/r/20240909195939.067c1c13@canb.auug.org.au
> >
> > The conflict was because the below commit
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/commit/?h=for-next/hardening&id=3ff37dbb1ae9926d3b51749f7d0d3f474fe2440b
> >
> > Jani suggested to rename or remove it in
> > https://patchwork.freedesktop.org/patch/612760/?series=136477&rev=5.
> >
> > Removed it for now, will add it once the commit is in the tree
>
> I think this should just be solved as normal merge conflict.
>
> It's already solved in linux-next with the right conflict resolution,
> which is to drop the local helper from drivers/gpu/drm/xe/xe_gt_idle.c
> and just use the helper from include/linux/string_choices.h.
> No need to drop it here and then eventually bringing the same change
> back.
Well, indeed. Since the function is exactly the same let's just do it.
>
> Lucas De Marchi
next prev parent reply other threads:[~2024-09-10 17:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 14:28 [PATCH] drm/xe/xe_gt_idle: Fix name conflict Riana Tauro
2024-09-10 14:52 ` Rodrigo Vivi
2024-09-10 14:54 ` Matthew Brost
2024-09-10 16:25 ` Riana Tauro
2024-09-10 16:39 ` Rodrigo Vivi
2024-09-10 16:48 ` Lucas De Marchi
2024-09-10 17:23 ` Rodrigo Vivi [this message]
2024-09-10 17:45 ` Rodrigo Vivi
2024-09-11 6:39 ` Riana Tauro
2024-09-11 20:53 ` Rodrigo Vivi
2024-09-10 16:26 ` ✓ CI.Patch_applied: success for " Patchwork
2024-09-10 16:26 ` ✓ CI.checkpatch: " Patchwork
2024-09-10 16:27 ` ✓ CI.KUnit: " Patchwork
2024-09-10 16:39 ` ✓ CI.Build: " Patchwork
2024-09-10 16:42 ` ✓ CI.Hooks: " Patchwork
2024-09-10 16:43 ` ✓ CI.checksparse: " Patchwork
2024-09-10 16:57 ` ✓ CI.BAT: " Patchwork
2024-09-10 20:11 ` ✗ CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuCAnYNYC8_ICcKC@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=lucas.demarchi@intel.com \
--cc=matthew.brost@intel.com \
--cc=riana.tauro@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).