intel-xe.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 00/43] Stop using xe_gt as a register MMIO target
@ 2024-09-10 23:47 Matt Roper
  2024-09-10 23:47 ` [PATCH v3 01/43] drm/xe: Move forcewake to 'gt.pm' substructure Matt Roper
                   ` (50 more replies)
  0 siblings, 51 replies; 58+ messages in thread
From: Matt Roper @ 2024-09-10 23:47 UTC (permalink / raw)
  To: intel-xe; +Cc: matthew.d.roper

A "GT" is just one subunit of an Intel GPU (i.e., the part that contains
the hardware engines, GuC, and programmable execution units).  It is not
directly related to register MMIO, although a subset of the registers
our driver interacts with are within the GT.  The driver also interacts
with, and programs, several other parts of the GPU that live outside the
GT (e.g., sgunit, pcode, display, etc.), so using an 'xe_gt' structure
in the driver as the target for all MMIO register operations causes a
lot of confusion and doesn't match how the hardware is actually
organized.

For register MMIO operations, the things that truly matter are:
 * Where the MMIO region is mapped for CPU access.
 * Any extra offset that should be "automatically" added to some
   xe_reg offsets.  (e.g., the 0x380000 offset for GSI registers in the
   media GT)
 * Extra metadata for size, valid/invalid subregions of the map, etc.
   that can be utilized by debug builds to perform extra checks and
   assertions to catch coding mistakes.

Let's add a dedicated 'xe_mmio' structure that encapsulates this
specific information and can be used as a target for MMIO operations.
For now an xe_mmio structure is present inside every xe_gt and xe_tile,
and can be used as the target for GT and non-GT operations respectively.
In the future additional xe_mmio substructures can be added for other
specific cases.

Note that there's a (currently unused) "mmio_ext" infrastructure in the
driver that appears to be an attempt to work around the GT-centric way
the driver has been doing register MMIO.  That infrastructure is simply
replaced with an additional instance of "struct xe_mmio" that lives at
the tile level.  This will allow standard register access logic for
accessing non-GT registers that exist in a very different BAR region
and/or reside in a different iomap.  Once code actually shows up to use
"mmio_ext" it will probably get renamed and accessed via "xe_foo->mmio"
or "xe_mmio_for_foo(xe)."

Once this general refactor lands, a follow-up will be add some extra
checking in debug builds to catch cases where the driver might be
performing MMIO accesses incorrectly (for example, accessing GT
registers through a non-GT MMIO which wouldn't apply proper GSI
offsets).

Since converting the entire driver from xe_gt to xe_mmio for register
access operations is a lot of churn, the original conversion includes
some _Generic compatibility defines to temporarily allow either xe_gt or
xe_mmio to be used.  This allows individual parts of the driver to be
converted in separate patches for ease of review.  The compatibility
macros are removed again at the end of the series.


v2:
 - Assorted naming and kerneldoc tweaks suggested during review (Lucas,
   Michal).
 - Store xe_tile backpointer instead of xe_device in xe_mmio since we
   can still get to the device from it, but all register MMIO is
   currently tile-centric so this could let us do better debug logging
   and such.  (Michal).
 - Keep an actual GT backpointer for the SRIOV special case rather than
   an SRIOV backpointer.  But name it so that it's very clear that it
   can only be used for SRIOV VF purposes and won't be set otherwise.
   (Michal)

v3:
 - Move removal of _Generic wrapper for all functions to the final
   patch; don't remove the wrapper with the last user for 8/16-bit reads
   or wait calls.  (Rodrigo)
 - A couple comment and commit message fixes and clarifications.
   (Rodrigo)

Matt Roper (43):
  drm/xe: Move forcewake to 'gt.pm' substructure
  drm/xe: Create dedicated xe_mmio structure
  drm/xe: Clarify size of MMIO region
  drm/xe: Move GSI offset adjustment fields into 'struct xe_mmio'
  drm/xe: Populate GT's mmio iomap from tile during init
  drm/xe: Switch mmio_ext to use 'struct xe_mmio'
  drm/xe: Add xe_tile backpointer to xe_mmio
  drm/xe: Adjust mmio code to pass VF substructure to SRIOV code
  drm/xe: Switch MMIO interface to take xe_mmio instead of xe_gt
  drm/xe/irq: Convert register access to use xe_mmio
  drm/xe/pcode: Convert register access to use xe_mmio
  drm/xe/hwmon: Convert register access to use xe_mmio
  drm/xe/vram: Convert register access to use xe_mmio
  drm/xe/compat-i915: Convert register access to use xe_mmio
  drm/xe/lmtt: Convert register access to use xe_mmio
  drm/xe/stolen: Convert register access to use xe_mmio
  drm/xe/device: Convert register access to use xe_mmio
  drm/xe/pci: Convert register access to use xe_mmio
  drm/xe/wa: Convert register access to use xe_mmio
  drm/xe/uc: Convert register access to use xe_mmio
  drm/xe/guc: Convert register access to use xe_mmio
  drm/xe/huc: Convert register access to use xe_mmio
  drm/xe/gsc: Convert register access to use xe_mmio
  drm/xe/query: Convert register access to use xe_mmio
  drm/xe/mcr: Convert register access to use xe_mmio
  drm/xe/mocs: Convert register access to use xe_mmio
  drm/xe/hw_engine: Convert register access to use xe_mmio
  drm/xe/gt_throttle: Convert register access to use xe_mmio
  drm/xe/pat: Convert register access to use xe_mmio
  drm/xe/wopcm: Convert register access to use xe_mmio
  drm/xe/oa: Convert register access to use xe_mmio
  drm/xe/topology: Convert register access to use xe_mmio
  drm/xe/execlist: Convert register access to use xe_mmio
  drm/xe/gt_clock: Convert register access to use xe_mmio
  drm/xe/reg_sr: Convert register access to use xe_mmio
  drm/xe/gt: Convert register access to use xe_mmio
  drm/xe/sriov: Convert register access to use xe_mmio
  drm/xe/tlb: Convert register access to use xe_mmio
  drm/xe/gt_idle: Convert register access to use xe_mmio
  drm/xe/forcewake: Convert register access to use xe_mmio
  drm/xe/ggtt: Convert register access to use xe_mmio
  drm/xe/ccs_mode: Convert register access to use xe_mmio
  drm/xe/mmio: Drop compatibility macros

 .../drm/xe/compat-i915-headers/intel_uncore.h |  36 ++---
 drivers/gpu/drm/xe/tests/xe_mocs.c            |   4 +-
 drivers/gpu/drm/xe/xe_assert.h                |   2 +-
 drivers/gpu/drm/xe/xe_device.c                |  37 +++--
 drivers/gpu/drm/xe/xe_device.h                |   3 +-
 drivers/gpu/drm/xe/xe_device_types.h          |  56 ++++++--
 drivers/gpu/drm/xe/xe_execlist.c              |  19 +--
 drivers/gpu/drm/xe/xe_force_wake.c            |   4 +-
 drivers/gpu/drm/xe/xe_ggtt.c                  |   8 +-
 drivers/gpu/drm/xe/xe_gsc.c                   |  23 +--
 drivers/gpu/drm/xe/xe_gsc_proxy.c             |   4 +-
 drivers/gpu/drm/xe/xe_gt.c                    |  10 +-
 drivers/gpu/drm/xe/xe_gt_ccs_mode.c           |   2 +-
 drivers/gpu/drm/xe/xe_gt_clock.c              |   6 +-
 drivers/gpu/drm/xe/xe_gt_freq.c               |   2 +-
 drivers/gpu/drm/xe/xe_gt_idle.c               |  21 +--
 drivers/gpu/drm/xe/xe_gt_mcr.c                |  39 ++---
 drivers/gpu/drm/xe/xe_gt_printk.h             |   2 +-
 drivers/gpu/drm/xe/xe_gt_sriov_pf.c           |   6 +-
 drivers/gpu/drm/xe/xe_gt_sriov_pf_service.c   |   6 +-
 drivers/gpu/drm/xe/xe_gt_sriov_vf.c           |   4 +-
 drivers/gpu/drm/xe/xe_gt_throttle.c           |   4 +-
 drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c   |   8 +-
 drivers/gpu/drm/xe/xe_gt_topology.c           |   8 +-
 drivers/gpu/drm/xe/xe_gt_types.h              |  22 +--
 drivers/gpu/drm/xe/xe_guc.c                   |  60 ++++----
 drivers/gpu/drm/xe/xe_guc_ads.c               |   2 +-
 drivers/gpu/drm/xe/xe_guc_pc.c                |  34 ++---
 drivers/gpu/drm/xe/xe_huc.c                   |   6 +-
 drivers/gpu/drm/xe/xe_hw_engine.c             |  29 ++--
 drivers/gpu/drm/xe/xe_hwmon.c                 |  16 +--
 drivers/gpu/drm/xe/xe_irq.c                   |  63 ++++----
 drivers/gpu/drm/xe/xe_lmtt.c                  |   2 +-
 drivers/gpu/drm/xe/xe_mmio.c                  | 134 +++++++++---------
 drivers/gpu/drm/xe/xe_mmio.h                  |  35 +++--
 drivers/gpu/drm/xe/xe_mocs.c                  |  16 +--
 drivers/gpu/drm/xe/xe_oa.c                    |  48 ++++---
 drivers/gpu/drm/xe/xe_pat.c                   |  14 +-
 drivers/gpu/drm/xe/xe_pci.c                   |  26 +++-
 drivers/gpu/drm/xe/xe_pcode.c                 |   4 +-
 drivers/gpu/drm/xe/xe_query.c                 |   7 +-
 drivers/gpu/drm/xe/xe_reg_sr.c                |  17 +--
 drivers/gpu/drm/xe/xe_sriov.c                 |   2 +-
 drivers/gpu/drm/xe/xe_trace.h                 |   7 +-
 drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c        |   8 +-
 drivers/gpu/drm/xe/xe_uc_fw.c                 |  17 +--
 drivers/gpu/drm/xe/xe_vram.c                  |   7 +-
 drivers/gpu/drm/xe/xe_wa.c                    |   4 +-
 drivers/gpu/drm/xe/xe_wopcm.c                 |  12 +-
 49 files changed, 492 insertions(+), 414 deletions(-)

-- 
2.45.2


^ permalink raw reply	[flat|nested] 58+ messages in thread

end of thread, other threads:[~2024-09-11 22:47 UTC | newest]

Thread overview: 58+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-10 23:47 [PATCH v3 00/43] Stop using xe_gt as a register MMIO target Matt Roper
2024-09-10 23:47 ` [PATCH v3 01/43] drm/xe: Move forcewake to 'gt.pm' substructure Matt Roper
2024-09-10 23:47 ` [PATCH v3 02/43] drm/xe: Create dedicated xe_mmio structure Matt Roper
2024-09-10 23:47 ` [PATCH v3 03/43] drm/xe: Clarify size of MMIO region Matt Roper
2024-09-10 23:47 ` [PATCH v3 04/43] drm/xe: Move GSI offset adjustment fields into 'struct xe_mmio' Matt Roper
2024-09-10 23:47 ` [PATCH v3 05/43] drm/xe: Populate GT's mmio iomap from tile during init Matt Roper
2024-09-10 23:47 ` [PATCH v3 06/43] drm/xe: Switch mmio_ext to use 'struct xe_mmio' Matt Roper
2024-09-10 23:47 ` [PATCH v3 07/43] drm/xe: Add xe_tile backpointer to xe_mmio Matt Roper
2024-09-10 23:47 ` [PATCH v3 08/43] drm/xe: Adjust mmio code to pass VF substructure to SRIOV code Matt Roper
2024-09-10 23:47 ` [PATCH v3 09/43] drm/xe: Switch MMIO interface to take xe_mmio instead of xe_gt Matt Roper
2024-09-11 20:34   ` Rodrigo Vivi
2024-09-10 23:47 ` [PATCH v3 10/43] drm/xe/irq: Convert register access to use xe_mmio Matt Roper
2024-09-10 23:47 ` [PATCH v3 11/43] drm/xe/pcode: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 12/43] drm/xe/hwmon: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 13/43] drm/xe/vram: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 14/43] drm/xe/compat-i915: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 15/43] drm/xe/lmtt: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 16/43] drm/xe/stolen: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 17/43] drm/xe/device: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 18/43] drm/xe/pci: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 19/43] drm/xe/wa: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 20/43] drm/xe/uc: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 21/43] drm/xe/guc: " Matt Roper
2024-09-11 20:35   ` Rodrigo Vivi
2024-09-10 23:47 ` [PATCH v3 22/43] drm/xe/huc: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 23/43] drm/xe/gsc: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 24/43] drm/xe/query: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 25/43] drm/xe/mcr: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 26/43] drm/xe/mocs: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 27/43] drm/xe/hw_engine: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 28/43] drm/xe/gt_throttle: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 29/43] drm/xe/pat: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 30/43] drm/xe/wopcm: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 31/43] drm/xe/oa: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 32/43] drm/xe/topology: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 33/43] drm/xe/execlist: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 34/43] drm/xe/gt_clock: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 35/43] drm/xe/reg_sr: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 36/43] drm/xe/gt: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 37/43] drm/xe/sriov: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 38/43] drm/xe/tlb: " Matt Roper
2024-09-10 23:47 ` [PATCH v3 39/43] drm/xe/gt_idle: " Matt Roper
2024-09-10 23:48 ` [PATCH v3 40/43] drm/xe/forcewake: " Matt Roper
2024-09-10 23:48 ` [PATCH v3 41/43] drm/xe/ggtt: " Matt Roper
2024-09-10 23:48 ` [PATCH v3 42/43] drm/xe/ccs_mode: " Matt Roper
2024-09-10 23:48 ` [PATCH v3 43/43] drm/xe/mmio: Drop compatibility macros Matt Roper
2024-09-11 20:35   ` Rodrigo Vivi
2024-09-10 23:55 ` ✓ CI.Patch_applied: success for Stop using xe_gt as a register MMIO target (rev3) Patchwork
2024-09-10 23:56 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-10 23:57 ` ✓ CI.KUnit: success " Patchwork
2024-09-11  0:09 ` ✓ CI.Build: " Patchwork
2024-09-11  0:11 ` ✓ CI.Hooks: " Patchwork
2024-09-11  0:13 ` ✓ CI.checksparse: " Patchwork
2024-09-11  0:55 ` ✗ CI.BAT: failure " Patchwork
2024-09-11 19:48   ` Matt Roper
2024-09-11  3:18 ` ✗ CI.FULL: " Patchwork
2024-09-11 19:52   ` Matt Roper
2024-09-11 22:46     ` Matt Roper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).